Issue 4568069: Switch trycaja to caja.js api

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4568069: Switch trycaja to caja.js api (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 5 months ago by Jasvir

Modified:
15 years, 4 months ago

Reviewers:
metaweta

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Uses caja.js api instead of directly invoking cajoled code in TryCaja * calls the cajoling service directly to get cajoled source for display by the shell * uses .contentCajoled to run @4501

Patch Set 1 #

Total comments: 6

Patch Set 2 : Switch trycaja to caja.js api #

Created: 15 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+220 lines, -185 lines)			Patch
	M	src/com/google/caja/demos/trycaja/index.html	View	1	1 chunk	+4 lines, -8 lines	0 comments	Download
	M	src/com/google/caja/demos/trycaja/js/trycaja.js	View	1	3 chunks	+216 lines, -177 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

metaweta

15 years, 5 months ago (2011-06-10 15:56:10 UTC) #2

lgtm mod formatting

http://codereview.appspot.com/4568069/diff/1/src/com/google/caja/demos/trycaj...
File src/com/google/caja/demos/trycaja/js/trycaja.js (right):

http://codereview.appspot.com/4568069/diff/1/src/com/google/caja/demos/trycaj...
src/com/google/caja/demos/trycaja/js/trycaja.js:27: {
indent

http://codereview.appspot.com/4568069/diff/1/src/com/google/caja/demos/trycaj...
src/com/google/caja/demos/trycaja/js/trycaja.js:37: }, function (frame) {
break line after comma

http://codereview.appspot.com/4568069/diff/1/src/com/google/caja/demos/trycaj...
src/com/google/caja/demos/trycaja/js/trycaja.js:97: className:
"jquery-console-message-error jquery-console-message-compile-error"
I think we care about line lengths in the <script> blocks of HTML files.

http://codereview.appspot.com/4568069/diff/1/src/com/google/caja/demos/trycaj...
src/com/google/caja/demos/trycaja/js/trycaja.js:158:
commandHandle:function(line,report) {
space after colon

http://codereview.appspot.com/4568069/diff/1/src/com/google/caja/demos/trycaj...
src/com/google/caja/demos/trycaja/js/trycaja.js:192:
charInsertTrigger:function(){
space after colon

http://codereview.appspot.com/4568069/diff/1/src/com/google/caja/demos/trycaj...
src/com/google/caja/demos/trycaja/js/trycaja.js:216: }
semicolon

Expand All Messages | Collapse All Messages