Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(88)

Issue 4560052: float texture painting enhancements

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 11 months ago by psy-fi
Modified:
10 years, 11 months ago
Reviewers:
brechtvl, letterrip, ideasman42, bf-codereview
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

Fixes refresh bug with float texture painting. Adds high resolution textures for float images to GUI. Makes float texture painting faster by only uploading part of the texture on the GPU Changes against trunk 36974 Pending for this patch is support for tiled textures. Also, smear tool still uploads bytes to the GUI.

Patch Set 1 #

Patch Set 2 : Cleaned-up version, omitting high-res stuff and merge problems #

Total comments: 3

Patch Set 3 : more cleanups, removed renames from other people's code, plus a function intended for high-res #

Patch Set 4 : forgot the function declaration #

Total comments: 7

Patch Set 5 : patch #

Patch Set 6 : A few more little corrections #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -29 lines) Patch
source/blender/blenkernel/BKE_brush.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
source/blender/blenkernel/intern/brush.c View 1 2 3 4 12 chunks +18 lines, -15 lines 0 comments Download
source/blender/blenlib/BLI_math_vector.h View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
source/blender/blenlib/BLI_utildefines.h View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
source/blender/blenlib/intern/math_vector_inline.c View 1 2 3 4 1 chunk +15 lines, -0 lines 0 comments Download
source/blender/editors/sculpt_paint/paint_image.c View 1 2 3 4 5 7 chunks +22 lines, -9 lines 0 comments Download
source/blender/gpu/intern/gpu_draw.c View 1 2 3 4 1 chunk +19 lines, -3 lines 0 comments Download
source/blender/imbuf/IMB_imbuf.h View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
source/blender/imbuf/intern/divers.c View 1 2 3 4 5 1 chunk +129 lines, -0 lines 0 comments Download

Messages

Total messages: 13
psy-fi
10 years, 11 months ago (2011-05-30 18:04:59 UTC) #1
psy-fi
Cleaned-up version, omitting high-res stuff and merge problems
10 years, 11 months ago (2011-05-30 19:49:39 UTC) #2
LetterRip
looks good asside from the repeating of the same 3 to 4 lines everywhere. http://codereview.appspot.com/4560052/diff/16002/source/blender/imbuf/intern/divers.c ...
10 years, 11 months ago (2011-05-30 21:41:35 UTC) #3
ideasman42
Looks fine, would prefer not to rename vars as a part of bugfixes, added comments ...
10 years, 11 months ago (2011-05-30 22:51:31 UTC) #4
psy-fi
more cleanups, removed renames from other people's code, plus a function intended for high-res
10 years, 11 months ago (2011-05-31 00:44:56 UTC) #5
psy-fi
forgot the function declaration
10 years, 11 months ago (2011-05-31 00:47:29 UTC) #6
brechtvl
Some comments below. http://codereview.appspot.com/4560052/diff/13006/source/blender/blenlib/BLI_utildefines.h File source/blender/blenlib/BLI_utildefines.h (right): http://codereview.appspot.com/4560052/diff/13006/source/blender/blenlib/BLI_utildefines.h#newcode110 source/blender/blenlib/BLI_utildefines.h:110: (v1)[3]=FTOCHAR((v2[3])); (v1)[3]=FTOCHAR((v2[3])) For multiple statement macros, ...
10 years, 11 months ago (2011-06-03 17:10:34 UTC) #7
psy-fi
OK, uploading another patch, this includes all the fixes proposed by brecht, including proper support ...
10 years, 11 months ago (2011-06-03 23:26:02 UTC) #8
psy-fi
patch
10 years, 11 months ago (2011-06-03 23:26:28 UTC) #9
psy-fi
Please check out my blog in a few minutes to see side-by-side differences http://psy-fidelity.blogspot.com/
10 years, 11 months ago (2011-06-03 23:29:14 UTC) #10
psy-fi
A few more little corrections
10 years, 11 months ago (2011-06-04 01:26:00 UTC) #11
brechtvl
LGTM. You can commit this to trunk then. And the float color blending does indeed ...
10 years, 11 months ago (2011-06-06 09:31:44 UTC) #12
brechtvl
10 years, 11 months ago (2011-06-06 09:41:35 UTC) #13
A bit late, but added bf-codereview to reviewers lists for logging purposes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b