Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38)

Issue 4536075: code review 4536075: http: add docs/warning on incorrect use of NewChunkedWriter (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by bradfitz
Modified:
10 years, 6 months ago
Reviewers:
CC:
golang-dev, adg, r
Visibility:
Public.

Description

http: add docs/warning on incorrect use of NewChunkedWriter

Patch Set 1 #

Patch Set 2 : diff -r fef68b8eefba https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r fef68b8eefba https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 4 : diff -r fef68b8eefba https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/pkg/http/chunked.go View 1 2 3 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 5
bradfitz
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 6 months ago (2011-05-22 22:41:32 UTC) #1
adg
LGTM http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go File src/pkg/http/chunked.go (right): http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go#newcode21 src/pkg/http/chunked.go:21: // would result in double chunking or chunking ...
10 years, 6 months ago (2011-05-23 00:03:44 UTC) #2
r
LGTM http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go File src/pkg/http/chunked.go (right): http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go#newcode19 src/pkg/http/chunked.go:19: // package adds chunking automatically if Handlers don't ...
10 years, 6 months ago (2011-05-23 00:45:45 UTC) #3
bradfitz
*** Submitted as http://code.google.com/p/go/source/detail?r=b683b10bb780 *** http: add docs/warning on incorrect use of NewChunkedWriter R=golang-dev, adg, ...
10 years, 6 months ago (2011-05-23 01:46:55 UTC) #4
bradfitz
10 years, 6 months ago (2011-05-23 01:47:09 UTC) #5

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b