code review 4536075: http: add docs/warning on incorrect use of NewChunkedWriter

http: add docs/warning on incorrect use of NewChunkedWriter

[bradfitz, 2011-05-22 22:41:32]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[adg, 2011-05-23 00:03:44]

LGTM

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go
File src/pkg/http/chunked.go (right):

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go#newco...
src/pkg/http/chunked.go:21: // would result in double chunking or chunking with
a pre-declared
s/pre-declared/set Content-Length/

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go#newco...
src/pkg/http/chunked.go:25: log.Printf("incorrect use of NewChunkedWriter in an
http.Handler; expect corrupt output")
warning: using NewChunkedWriter inside an http.Handler; expect corrupt output

[r, 2011-05-23 00:45:45]

LGTM

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go
File src/pkg/http/chunked.go (right):

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go#newco...
src/pkg/http/chunked.go:19: // package adds chunking automatically if Handlers
don't set a
s/Handler/handler/g

[bradfitz, 2011-05-23 01:46:55]

*** Submitted as http://code.google.com/p/go/source/detail?r=b683b10bb780 ***

http: add docs/warning on incorrect use of NewChunkedWriter

R=golang-dev, adg, r
CC=golang-dev
http://codereview.appspot.com/4536075

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go
File src/pkg/http/chunked.go (right):

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go#newco...
src/pkg/http/chunked.go:19: // package adds chunking automatically if Handlers
don't set a
On 2011/05/23 00:45:45, r wrote:
> s/Handler/handler/g

Done.

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go#newco...
src/pkg/http/chunked.go:21: // would result in double chunking or chunking with
a pre-declared
On 2011/05/23 00:03:44, adg wrote:
> s/pre-declared/set Content-Length/

Done.

http://codereview.appspot.com/4536075/diff/3001/src/pkg/http/chunked.go#newco...
src/pkg/http/chunked.go:25: log.Printf("incorrect use of NewChunkedWriter in an
http.Handler; expect corrupt output")
On 2011/05/23 00:03:44, adg wrote:
> warning: using NewChunkedWriter inside an http.Handler; expect corrupt output

Done.