Let's create a wiki page with more details and examples, then link to it from ...
12 years, 11 months ago
(2011-05-23 19:16:35 UTC)
#3
Let's create a wiki page with more details and examples, then link to it
from the comments here... I think that the description of how to define
multiple options with one extension number is probably difficult to
understand without an example. Also, let's replace my e-mail address with
yours or someone else on the team.
On Sun, May 22, 2011 at 7:57 PM, <liujisi@google.com> wrote:
> http://codereview.appspot.com/4535095/
>
Never mind about the wiki page, I see you are adding this info to the ...
12 years, 11 months ago
(2011-05-23 19:33:53 UTC)
#4
Never mind about the wiki page, I see you are adding this info to the docs.
We should link to the docs here.
On Mon, May 23, 2011 at 12:16 PM, Kenton Varda <kenton@google.com> wrote:
> Let's create a wiki page with more details and examples, then link to it
> from the comments here... I think that the description of how to define
> multiple options with one extension number is probably difficult to
> understand without an example. Also, let's replace my e-mail address with
> yours or someone else on the team.
>
>
> On Sun, May 22, 2011 at 7:57 PM, <liujisi@google.com> wrote:
>
>> http://codereview.appspot.com/4535095/
>>
>
>
LGTM http://codereview.appspot.com/4535095/diff/6001/src/google/protobuf/descriptor.proto File src/google/protobuf/descriptor.proto (right): http://codereview.appspot.com/4535095/diff/6001/src/google/protobuf/descriptor.proto#newcode228 src/google/protobuf/descriptor.proto:228: // putting them in a sub-message. See the ...
12 years, 11 months ago
(2011-05-24 16:59:03 UTC)
#6
Thanks, submitting. http://codereview.appspot.com/4535095/diff/6001/src/google/protobuf/descriptor.proto File src/google/protobuf/descriptor.proto (right): http://codereview.appspot.com/4535095/diff/6001/src/google/protobuf/descriptor.proto#newcode228 src/google/protobuf/descriptor.proto:228: // putting them in a sub-message. See ...
12 years, 11 months ago
(2011-05-25 06:23:51 UTC)
#7
Issue 4535095: Update global custom options extension number comments.
Created 12 years, 11 months ago by Jisi Liu
Modified 12 years, 11 months ago
Reviewers: kenton
Base URL: http://protobuf.googlecode.com/svn/trunk/
Comments: 2