code review 4535090: dbus: initial check-in of a D-Bus library.

dbus: initial check-in of a D-Bus library.

Only client method calls for now, not server method replies or signals.

[nigeltao, 2011-05-20 16:42:31]

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://dbus-go.googlecode.com/hg/

[nigeltao, 2011-05-20 16:44:27]

Note that this package lives at http://code.google.com/p/dbus-go/, and
is not part of the standard package library.

[nigeltao, 2011-05-25 21:43:14]

bradfitz: ping.

[bradfitz, 2011-05-31 19:14:00]

Haven't tried it yet but will try to today.

http://codereview.appspot.com/4535090/diff/5001/dbus/conn.go
File dbus/conn.go (right):

http://codereview.appspot.com/4535090/diff/5001/dbus/conn.go#newcode221
dbus/conn.go:221: func (c *Conn) Call(dst, objectPath, iface, method, argSig
string, arg ...interface{}) (Array, os.Error) {
this feels like way too many positional strings.

what about something like:

type Object struct {
    Destination, Path string
}

type Method struct {
    Method, Sig string  
}

Then they have nice names:

dbus.Object
dbus.Method

And Call could be:

func (c *Conn) Call(o Object, m Method, arg ...interface{}) (Array, os.Error)

http://codereview.appspot.com/4535090/diff/5001/dbus/conn.go#newcode222
dbus/conn.go:222: replyc := make(chan reply)
Unless there's good reason, I tend to make channels buffered, even if they're
just receiving one value:  it prevents goroutines from being blocked forever and
un-collectable on sends during error paths.

make(chan reply, 1)

http://codereview.appspot.com/4535090/diff/5001/dbus/dbus.go
File dbus/dbus.go (right):

http://codereview.appspot.com/4535090/diff/5001/dbus/dbus.go#newcode19
dbus/dbus.go:19: //		"iis",
I wonder if we could do something with Go interface types and reflect here to
make signature creation automatic in most cases.  They could still create a
&dbus.Method{...} if they want, but they could also use a helper function to
create a Method based on the reflect signature of some method and its Go types. 
*shrug*

http://codereview.appspot.com/4535090/diff/5001/dbus/dbus.go#newcode56
dbus/dbus.go:56: if len(b) < 3 || b[0] != 'O' || b[1] != 'K' || (b[2] != ' ' &&
b[2] != '\r') {
oh, annoying that the ' ' vs '\r' means you can't just use bytes.HasPrefix.

http://codereview.appspot.com/4535090/diff/5001/dbus/dbus.go#newcode73
dbus/dbus.go:73: b, err = ioutil.ReadFile(os.Getenv("HOME") +
"/.dbus/session-bus/" + strings.TrimSpace(string(b)) + "-0")
before you look in this file, aren't you supposed to look at
os.Getenv("DBUS_SESSION_BUS_ADDRESS")?  Only if that's missing I think then do
you look in ~/.dbus/session-bus/

[bsiegert, 2012-11-09 13:12:55]

ping?

[bradfitz, 2012-11-09 15:56:46]

What's this ping about?

Nigel (currently on vacation) has handed this off to tbushnell, who's
currently working on this in a separate CL.

On Fri, Nov 9, 2012 at 5:12 AM, <bsiegert@gmail.com> wrote:

> ping?
>
>
https://codereview.appspot.**com/4535090/<https://codereview.appspot.com/4535...
>

[bsiegert, 2012-11-12 10:10:07]

OK, thanks!

On Fri, Nov 9, 2012 at 4:56 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> What's this ping about?
>
> Nigel (currently on vacation) has handed this off to tbushnell, who's
> currently working on this in a separate CL.
>
> On Fri, Nov 9, 2012 at 5:12 AM, <bsiegert@gmail.com> wrote:
>>
>> ping?
>>
>> https://codereview.appspot.com/4535090/
>
>



-- 
The first essential in chemistry is that you should perform practical
work and conduct experiments, for he who performs not practical work
nor makes experiments will never attain the least degree of mastery.
        -- Abu Musa Jabir ibn Hayyan (721-815)

[bradfitz, 2013-06-28 19:16:46]

R=close

Others have forked this elsewhere.