detect Host and Port from HttpServletRequest

Please see description from here:
https://issues.apache.org/jira/browse/SHINDIG-1534

[WoodstaE, 2011-05-12 14:23:56]

On 2011/05/11 21:21:44, Li Xu wrote:

Li, I'm seeing the following test cases fail after applying your patch:

  fetchPerson(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  fetchPeople(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  messageBundles(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  viewLevelElements(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testMakeRequest(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  messageBundlesRtl(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  notFoundError(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  badRequest(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  internalError(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testTemplates(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testFailCaja(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testPipelining(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testOsapiPeople(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testOsapiPerson(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testOsapiActivities(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testOsapiAppdataFetchId(org.apache.shindig.server.endtoend.EndToEndTest): 404
Not Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testOsapiAppdataAppDataWrite(org.apache.shindig.server.endtoend.EndToEndTest):
404 Not Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testOsapiBatch(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testTemplateRewrite(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
  testTemplateLibrary(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found for
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...

[mgmarum, 2011-05-12 19:03:11]

I just made a first pass that focused mostly on style. 

In Shindig, they are particular about code style.  Basically 2 space indents, no
tab characters, and 100 column line width.  I commented where I saw issues.

See http://shindig.apache.org/community/conventions/code.html for more details.

Matt


On 2011/05/12 14:23:56, WoodstaE wrote:
> On 2011/05/11 21:21:44, Li Xu wrote:
> 
> Li, I'm seeing the following test cases fail after applying your patch:
> 
>   fetchPerson(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   fetchPeople(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   messageBundles(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   viewLevelElements(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
> Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testMakeRequest(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
> Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   messageBundlesRtl(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
> Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   notFoundError(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   badRequest(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   internalError(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testTemplates(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testFailCaja(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testPipelining(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testOsapiPeople(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
> Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testOsapiPerson(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
> Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testOsapiActivities(org.apache.shindig.server.endtoend.EndToEndTest): 404
Not
> Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testOsapiAppdataFetchId(org.apache.shindig.server.endtoend.EndToEndTest):
404
> Not Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>  
testOsapiAppdataAppDataWrite(org.apache.shindig.server.endtoend.EndToEndTest):
> 404 Not Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testOsapiBatch(org.apache.shindig.server.endtoend.EndToEndTest): 404 Not
Found
> for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testTemplateRewrite(org.apache.shindig.server.endtoend.EndToEndTest): 404
Not
> Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...
>   testTemplateLibrary(org.apache.shindig.server.endtoend.EndToEndTest): 404
Not
> Found for
>
http://localhost:8080/gadgets/js/core:rpc.js?container=default&nocache=1&debu...

[mgmarum, 2011-05-12 19:03:54]

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
File java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java
(right):

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java:46:
// TODO Auto-generated method stub
Remove TODO markers

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
File
java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java
(right):

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java:26:
String auth = req.getServerName() + ":" + req.getServerPort();
2 space indent

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java:36:
* A Thread Local holder for authority -- host + port
Nit, some indentation off in these comments.

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java:60:
String retVal = fullAuthority.get();
nitpick, indentation off within this method.

[Li Xu, 2011-05-12 19:36:29]

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
File java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java
(right):

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java:46:
// TODO Auto-generated method stub
On 2011/05/12 19:03:54, mgmarum wrote:
> Remove TODO markers

Done.

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
File
java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java
(right):

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java:26:
String auth = req.getServerName() + ":" + req.getServerPort();
On 2011/05/12 19:03:54, mgmarum wrote:
> 2 space indent

Done.

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java:36:
* A Thread Local holder for authority -- host + port
On 2011/05/12 19:03:54, mgmarum wrote:
> Nit, some indentation off in these comments.

Done.

http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/ap...
java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java:60:
String retVal = fullAuthority.get();
On 2011/05/12 19:03:54, mgmarum wrote:
> nitpick, indentation off within this method.

Done.

[Li Xu, 2011-05-12 19:37:48]

fixed tests and code style *please review*

[WoodstaE, 2011-05-12 20:02:29]

On 2011/05/12 19:37:48, Li Xu wrote:
> fixed tests and code style *please review*

Committed.  Thanks, Li.