Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(97)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 4534049: detect Host and Port from HttpServletRequest

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 10 months ago by Li Xu
Modified:
14 years, 10 months ago
Reviewers:
Paul Lindner, henry.saputra, mgmarum, WoodstaE, dev-remailer, woodstae
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

Please see description from here: https://issues.apache.org/jira/browse/SHINDIG-1534

Patch Set 1 #

Total comments: 8

Patch Set 2 : fixed tests and code style *please review* #

Messages

Total messages: 7
Li Xu
14 years, 10 months ago (2011-05-11 21:21:44 UTC) #1
WoodstaE
On 2011/05/11 21:21:44, Li Xu wrote: Li, I'm seeing the following test cases fail after ...
14 years, 10 months ago (2011-05-12 14:23:56 UTC) #2
mgmarum
I just made a first pass that focused mostly on style. In Shindig, they are ...
14 years, 10 months ago (2011-05-12 19:03:11 UTC) #3
mgmarum
http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java File java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java (right): http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java#newcode46 java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java:46: // TODO Auto-generated method stub Remove TODO markers http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/apache/shindig/common/servlet/ServletRequestContext.java ...
14 years, 10 months ago (2011-05-12 19:03:54 UTC) #4
Li Xu
http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java File java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java (right): http://codereview.appspot.com/4534049/diff/1/java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java#newcode46 java/common/src/main/java/org/apache/shindig/common/servlet/HostFilter.java:46: // TODO Auto-generated method stub On 2011/05/12 19:03:54, mgmarum ...
14 years, 10 months ago (2011-05-12 19:36:29 UTC) #5
Li Xu
fixed tests and code style *please review*
14 years, 10 months ago (2011-05-12 19:37:48 UTC) #6
WoodstaE
14 years, 10 months ago (2011-05-12 20:02:29 UTC) #7 
On 2011/05/12 19:37:48, Li Xu wrote:
> fixed tests and code style *please review*

Committed.  Thanks, Li.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b