Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1552)

Issue 4529048: MDef BVH Support

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by joeedh
Modified:
9 years, 3 months ago
Reviewers:
bf-codereview, lukas.toenne, zanqdo, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -49 lines) Patch
M source/blender/editors/armature/meshlaplacian.c View 5 chunks +50 lines, -49 lines 2 comments Download

Messages

Total messages: 10
lukas.toenne
Looks good to me, only the use of epsilon in bvhtree made me wonder, but ...
10 years, 4 months ago (2011-09-10 07:41:21 UTC) #1
brechtvl
The function meshdeform_tri_intersect has a big epsilon to ensure no rays slip through (float precision ...
10 years, 4 months ago (2011-09-10 08:10:31 UTC) #2
zanqdo_gmail.com
i'll develop a test suite for comparison based on this then cheers Daniel Salazar 3Developer.com ...
10 years, 4 months ago (2011-09-11 23:18:21 UTC) #3
zanqdo_gmail.com
Gah, sadly patch is failing in svn patching file source/blender/editors/armature/meshlaplacian.c Hunk #1 succeeded at 1106 ...
10 years, 3 months ago (2011-09-26 01:43:14 UTC) #4
lukas.toenne
Fix for latest trunk (r40555 tested), need explicit conversion to non-const vector argument. http://codereview.appspot.com/4529048/diff/1/source/blender/editors/armature/meshlaplacian.c File ...
10 years, 3 months ago (2011-09-26 08:41:19 UTC) #5
zanqdo_gmail.com
Lukas it seems it's failing again could someone fix the patch? cheers Daniel Salazar 3Developer.com ...
10 years, 2 months ago (2011-10-27 20:51:12 UTC) #6
zanqdo_gmail.com
I'm trying this patch http://codereview.appspot.com/4529048/diff/1/source/blender/editors/armature/meshlaplacian.c#newcode1187 do I need anything else? cheers Daniel Salazar 3Developer.com On ...
10 years, 2 months ago (2011-10-27 21:01:11 UTC) #7
zanqdo_gmail.com
Here's an updated patch for r50858 by dfelinto http://www.pasteall.org/35522/diff Daniel Salazar patazstudio.com On Thu, Oct ...
9 years, 3 months ago (2012-09-24 19:14:02 UTC) #8
brechtvl
Committed patch to svn now.
9 years, 3 months ago (2012-10-04 20:37:36 UTC) #9
zanqdo_gmail.com
9 years, 3 months ago (2012-10-04 20:58:03 UTC) #10
YES! This is big, than you very much!

Daniel Salazar
patazstudio.com


On Thu, Oct 4, 2012 at 2:37 PM,  <brechtvanlommel@gmail.com> wrote:
> Committed patch to svn now.
>
> https://codereview.appspot.com/4529048/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b