Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(303)

Issue 4528061: Start towards fixing the tie / time signature collision problem. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by MikeSol
Modified:
7 years, 11 months ago
Reviewers:
mike, carl.d.sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Start towards fixing the tie / time signature collision problem.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -9 lines) Patch
M lily/arpeggio.cc View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/lookup.hh View 1 chunk +1 line, -1 line 0 comments Download
M lily/include/tie.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/lookup.cc View 2 chunks +30 lines, -5 lines 0 comments Download
M lily/slur.cc View 1 chunk +4 lines, -1 line 0 comments Download
M lily/tie.cc View 4 chunks +80 lines, -1 line 0 comments Download
A lily/tie-collision-engraver.cc View 1 chunk +108 lines, -0 lines 0 comments Download
M lily/tie-engraver.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ly/engraver-init.ly View 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 2 chunks +2 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
MikeSol
I recently tried to redo a score such that my ties did not intersect with ...
8 years ago (2011-05-13 00:40:23 UTC) #1
Carl
I didn't follow everything you've done, because I didn't have time to look through it ...
8 years ago (2011-05-13 02:52:47 UTC) #2
mike_apollinemike.com
8 years ago (2011-05-13 09:30:37 UTC) #3
Thanks Carl!
I changed my code to use the extent method from Bezier, and it looks like
nothing (or not much) changed in the visuals. Will post a new version once I get
home. In the meantime, if anyone has a chance to play around with it, lemme know
if you can get a good result and/or other suspicions as to why the result is
bad.

~Mike



On May 12, 2011, at 22:52, Carl.D.Sorensen@gmail.com wrote:

> I didn't follow everything you've done, because I didn't have time to
> look through it all in detail.
> 
> You should be aware, however, that the points for the tie are different
> from the extents.  The left end of a tie will be at t = -delta, rather
> than at t=0.  This is because of the width of the curve; the bezier
> curve goes through the center of the ink; there's a non-zero width to
> the bezier.
> 
> I'm not sure if this is responsible for your difficulties, but I think
> it may be.
> 
> HTH,
> 
> Carl
> 
> 
> http://codereview.appspot.com/4528061/
> 
> _______________________________________________
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-devel
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b