Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(324)

Issue 4528051: Joomla master .htaccess - differences 2.4.9 - 3.3.c

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by g1smd
Modified:
12 years, 11 months ago
Reviewers:
nikosdion
Base URL:
http://joomla-master-htaccess.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Based on the version 2.3 code originally found at: http://snipt.net/nikosdion/the-master-htaccess/ and now listed at: http://code.google.com/p/joomla-master-htaccess/source/browse/trunk/joomla-master-htaccess.txt?spec=svn2&r=2 The original file contains a number of syntax errors, several rules that can never work, and a number of expressions that can be more efficiently coded. Bugs and enhancements originally discussed at: http://forum.joomla.org/viewtopic.php?f=432&t=549841 Discussion also at: http://snipt.net/nikosdion/the-master-htaccess/ The new 2.4.9 proposed file: http://snipt.net/g1smd/joomla-master-htaccess-file-proposed-v24-2011-05-../ or at: http://code.google.com/p/joomla-master-htaccess/source/browse/trunk/joomla-master-htaccess.txt?spec=svn2&r=29 NOTE: this is <!--not--> now the latest version of the file. Continued in: http://codereview.appspot.com/......./

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -45 lines) Patch
joomla-master-htaccess.txt View 16 chunks +59 lines, -45 lines 12 comments Download

Messages

Total messages: 1
g1smd
12 years, 11 months ago (2011-05-10 16:08:17 UTC) #1
http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt
File joomla-master-htaccess.txt (right):

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:286: ## These are sample exceptions to the Advanced
Server Protection 3.0
Much changed since last tagged 3.0.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:321: # Advanced server protection, version 2.0 -
August 2010
Much changed since last tagged 2.0.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:328: RewriteRule
^images/stories/.*\.(jp(e?g|2)?|png|gif|bmp|css|js|swf|ico)$ - [L]
Use a better pattern. See 2.4.9.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:355: RewriteRule
^administrator/(components|modules|templates|images|plugins)/.*\.(jp(e?g|2)?|png|gif|bmp|css|js|swf|html?|mp(eg?|[34])|avi|wav|og[gv]|xlsx?|docx?|pptx?|zip|rar|pdf|xps|txt|7z|svg|od[tsp]|flv|mov)$
- [L]
Use a better pattern. See 2.4.9.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:367: RewriteRule
^(components|modules|plugins|templates)/.*\.(jp(e?g|2)?|png|gif|bmp|css|js|swf|html?|mp(eg?|[34])|avi|wav|og[gv]|xlsx?|docx?|pptx?|zip|rar|pdf|xps|txt|7z|svg|od[tsp]|flv|mov)$
- [L]
Use a better pattern. See 2.4.9.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:371: # RewriteRule
^(components|modules|plugins|templates)/.*(index\.php)?$ - [L]
Use a better pattern. See 2.4.9.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:374: # RewriteRule ^templates/.*\.php$ - [L]
Use a better pattern. See 2.4.9.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:378: RewriteCond %{REQUEST_FILENAME} (\.php)$
Backreference not needed.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:379: RewriteCond %{REQUEST_FILENAME}
!(/index[23]?\.php)$
Backreference not needed.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:381: RewriteRule (.*\.php)$ - [F]
Use a better pattern. See 2.4.9.
Backreference not needed.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:383: ## Disallow access to htaccess.txt and
configuration.php-dist
... and php.ini.

http://codereview.appspot.com/4528051/diff/1/joomla-master-htaccess.txt#newco...
joomla-master-htaccess.txt:420: RewriteCond %{REQUEST_URI}
/component/|(/[^.]*|\.(php|html?|feed|pdf|raw|ini|zip|json|file|vcf))$ [NC]
vcf is not on the end of the list in the official .htaccess file.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b