Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 4527099: Playground needs to mark GWT's frame as feral (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 5 months ago by felix8a
Modified:
15 years, 5 months ago
Reviewers:
Jasvir, ihab.awad
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

So the future of FERAL_FRAME_OBJECT___ is under discussion, but in the meantime, this change makes the Playground policy tab work again. The reason it doesn't work is the policy is eval'ed in GWT's frame, and that frame does not have the Object.FERAL_FRAME_OBJECT___ marker, so anything defined in the policy will tame to undefined. This change adds a call to initFeralFrame(), which will add that marker.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/com/google/caja/demos/playground/client/ui/PlaygroundView.java View 1 chunk +3 lines, -1 line 0 comments Download
M src/com/google/caja/plugin/caja.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
felix8a
15 years, 5 months ago (2011-06-06 21:43:26 UTC) #1
ihab.awad
lgtm
15 years, 5 months ago (2011-06-06 22:53:05 UTC) #2
felix8a
15 years, 5 months ago (2011-06-06 22:55:47 UTC) #3
@r4494
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b