Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96)

Issue 4527098: code review 4527098: gc: enable building under clang/2.9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by dfc
Modified:
7 years, 9 months ago
Reviewers:
rsc
CC:
jmhodges, r, ality, golang-dev
Visibility:
Public.

Description

gc: enable building under clang/2.9 To build under clang, pass the path to clang in CC when calling ./make.bash CC=/opt/llvm/llvm-2.9/bin/clang ./make.bash Credit goes to jmhodges for suggestions.

Patch Set 1 #

Patch Set 2 : diff -r 2f0e2512948c https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 3 : diff -r 2f0e2512948c https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r 2f0e2512948c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/cmd/gc/subr.c View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14
jmhodges
http://codereview.appspot.com/4527098/diff/4/src/cmd/gc/subr.c File src/cmd/gc/subr.c (left): http://codereview.appspot.com/4527098/diff/4/src/cmd/gc/subr.c#oldcode108 src/cmd/gc/subr.c:108: *(int*)0 = 0; Alternatively, this could be done with ...
7 years, 9 months ago (2011-06-06 07:16:40 UTC) #1
dfc
Hello jeff@somethingsimilar.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
7 years, 9 months ago (2011-06-06 07:20:25 UTC) #2
r
http://codereview.appspot.com/4527098/diff/3001/src/cmd/gc/subr.c File src/cmd/gc/subr.c (right): http://codereview.appspot.com/4527098/diff/3001/src/cmd/gc/subr.c#newcode108 src/cmd/gc/subr.c:108: __builtin_trap(); is there a reason not to call abort()?
7 years, 9 months ago (2011-06-06 07:55:51 UTC) #3
ality
dave@cheney.net once said: > - *(int*)0 = 0; > + __builtin_trap(); I'm suprised clang won't ...
7 years, 9 months ago (2011-06-06 08:03:19 UTC) #4
jmhodges
On 2011/06/06 07:55:51, r wrote: > http://codereview.appspot.com/4527098/diff/3001/src/cmd/gc/subr.c > File src/cmd/gc/subr.c (right): > > http://codereview.appspot.com/4527098/diff/3001/src/cmd/gc/subr.c#newcode108 > ...
7 years, 9 months ago (2011-06-06 08:18:04 UTC) #5
jmhodges
7 years, 9 months ago (2011-06-06 08:22:33 UTC) #6
dfc
Thanks for the feedback. PTAL.
7 years, 9 months ago (2011-06-06 08:53:32 UTC) #7
jmhodges
LGTM
7 years, 9 months ago (2011-06-06 08:57:58 UTC) #8
r
LGTM
7 years, 9 months ago (2011-06-06 09:51:08 UTC) #9
r
*** Submitted as http://code.google.com/p/go/source/detail?r=6414e4f6b736 *** gc: enable building under clang/2.9 To build under clang, pass ...
7 years, 9 months ago (2011-06-06 09:53:48 UTC) #10
dfc
Thanks Rob.
7 years, 9 months ago (2011-06-06 09:54:20 UTC) #11
rsc
I'm sad to see abort instead of *(int*)0 = 0. The former deposits you in ...
7 years, 9 months ago (2011-06-07 19:19:55 UTC) #12
jmhodges
Totally does, as my first comment pointed out! On Tue, Jun 7, 2011 at 12:19 ...
7 years, 9 months ago (2011-06-07 22:04:25 UTC) #13
dfc
7 years, 9 months ago (2011-06-08 00:28:57 UTC) #14
Hi Russ,

Please try http://codereview.appspot.com/4517143

Cheers

Dave

On Wed, Jun 8, 2011 at 5:19 AM, Russ Cox <rsc@golang.org> wrote:
> I'm sad to see abort instead of *(int*)0 = 0.
> The former deposits you in the bowels of glibc
> while the latter leaves you in the actual program
> you want to debug.
>
> Does clang let you do *(volatile int*)0 = 0 ?
>
> Russ
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b