Issue 4517143: code review 4517143: gc: alternative clang compatible abort.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4517143: code review 4517143: gc: alternative clang compatible abort. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 10 months ago by dave

Modified:
12 years, 10 months ago

Reviewers:

CC:
rsc, jmhodges, r, golang-dev

Visibility:
Public.

Description

gc: alternative clang compatible abort. Tested on clang 2.9/amd64

Patch Set 1 #

Patch Set 2 : diff -r 082e18eba53b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 082e18eba53b https://go.googlecode.com/hg/ #

Created: 12 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/cmd/gc/subr.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dave_cheney.net

Hello rsc@golang.org, jeff@somethingsimilar.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 10 months ago (2011-06-08 00:28:56 UTC) #1

*** Submitted as http://code.google.com/p/go/source/detail?r=58515a4de582 *** gc: alternative clang compatible abort. Tested on clang 2.9/amd64 R=rsc, ...

12 years, 10 months ago (2011-06-08 00:46:28 UTC) #4

rsc

12 years, 10 months ago (2011-06-08 02:43:58 UTC) #5

thank you!

for the curious, it's very common when trying to debug
a compiler bug to narrow it down to a single error being
printed and then run the compiler under gdb with the -h flag,
so that you get a fault at the time of the error, so that
you can poke around at the context.

Expand All Messages | Collapse All Messages