Issue 4527056: Allow customization of host provision

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4527056: Allow customization of host provision (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by johnfargo

Modified:
15 years ago

Reviewers:
dev-remailer, mhermanto

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

Converts static ServletRequestContext into a Provider<String> of host. This CL doesn't go the whole way in that it doesn't restore SRC behavior by default -- will need that in a followup.

Patch Set 1 #

Created: 15 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+48 lines, -15 lines)			Patch
config/container.js	View	1 chunk	+4 lines, -4 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/DefaultJsProcessorRegistry.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/js/JsResponseBuilder.java	View	1 chunk	+1 line, -1 line	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultConcatUriManager.java	View	5 chunks	+10 lines, -3 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java	View	4 chunks	+10 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultJsUriManager.java	View	3 chunks	+11 lines, -2 lines	0 comments	Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultProxyUriManager.java	View	4 chunks	+10 lines, -2 lines	0 comments	Download
java/server/src/main/webapp/WEB-INF/web.xml	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

mhermanto

On 2011/05/13 20:07:14, johnfargo wrote: Perhaps TODO to this injection in one place, in ContainerConfig.getString().

15 years ago (2011-05-13 20:12:15 UTC) #2

mhermanto

On 2011/05/13 20:12:15, mhermanto wrote: > On 2011/05/13 20:07:14, johnfargo wrote: > > Perhaps TODO ...

15 years ago (2011-05-13 20:12:25 UTC) #3

mhermanto

On 2011/05/13 20:12:15, mhermanto wrote: > On 2011/05/13 20:07:14, johnfargo wrote: > > Perhaps TODO ...

15 years ago (2011-05-13 20:12:28 UTC) #4

johnfargo

15 years ago (2011-05-13 20:13:20 UTC) #6

Fantastic idea -- I agree, that's the better approach. Suggested that to the
Shindig community.

On 2011/05/13 20:12:36, mhermanto wrote:
> LGTM++

Expand All Messages | Collapse All Messages