Issue 4523049: Modify caja.js to call initFeralFrame() automatically.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4523049: Modify caja.js to call initFeralFrame() automatically. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by ihab.awad

Modified:
14 years, 11 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

http://code.google.com/p/google-caja/issues/detail?id=1352

Patch Set 2 : Modify caja.js to call initFeralFrame() automatically. #

Patch Set 3 : Modify caja.js to call initFeralFrame() automatically. #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
M	src/com/google/caja/plugin/caja.js	View	1 2	2 chunks	+3 lines, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/browser-test-case.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/es53-test-taming-errors.js	View	1	3 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

felix8a

http://codereview.appspot.com/4523049/diff/1/src/com/google/caja/plugin/caja.js File src/com/google/caja/plugin/caja.js (right): http://codereview.appspot.com/4523049/diff/1/src/com/google/caja/plugin/caja.js#newcode443 src/com/google/caja/plugin/caja.js:443: initFeralFrame(window); why call it here instead of in configure()? ...

14 years, 11 months ago (2011-05-09 20:54:24 UTC) #2

ihab.awad

Thanks, that is an improvement. Snapshotted. http://codereview.appspot.com/4523049/diff/1/src/com/google/caja/plugin/caja.js File src/com/google/caja/plugin/caja.js (right): http://codereview.appspot.com/4523049/diff/1/src/com/google/caja/plugin/caja.js#newcode443 src/com/google/caja/plugin/caja.js:443: initFeralFrame(window); On 2011/05/09 ...

14 years, 11 months ago (2011-05-09 22:58:17 UTC) #3

@4464

Expand All Messages | Collapse All Messages