Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(353)

Issue 4518053: Doc: NR 1.6.3 - edit eg.s in quoting other voices (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by pkx166h
Modified:
7 years, 12 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR 1.6.3 - edit eg.s in quoting other voices Suggestion from Keith O'Hara. An attempt to give a more realistic example than what was previously there. It also helps emphasise that it must be made at the top level but also that the order of the \quoteDurings and \addQuotes is not prescribed. Minor improvements of syntax and I moved around some of the information to make it flow more easily. Removed unnecessary text (either redundant, repeated or shown in the example).

Patch Set 1 #

Total comments: 16

Patch Set 2 : Second Draft #

Total comments: 2

Patch Set 3 : Third Draft #

Total comments: 2

Patch Set 4 : Fourth Draft #

Total comments: 14

Patch Set 5 : 5th draft #

Patch Set 6 : 6th Draft #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -61 lines) Patch
M Documentation/notation/staff.itely View 1 2 3 4 5 2 chunks +83 lines, -61 lines 0 comments Download

Messages

Total messages: 21
Graham Percival (old account)
http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1022 Documentation/notation/staff.itely:1022: @cindex quote, voices could we keep the old @cindex ...
8 years ago (2011-05-10 19:59:35 UTC) #1
Keith
My suggestion was tiny compared to this patch. http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (left): http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#oldcode1086 Documentation/notation/staff.itely:1086: Quotations ...
8 years ago (2011-05-11 03:26:40 UTC) #2
pkx166h
Second Draft http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1/Documentation/notation/staff.itely#newcode1022 Documentation/notation/staff.itely:1022: @cindex quote, voices On 2011/05/10 19:59:35, Graham ...
8 years ago (2011-05-11 16:15:25 UTC) #3
Keith
LGTM http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely#newcode1090 Documentation/notation/staff.itely:1090: The @code{\transposition} command can also be used with ...
8 years ago (2011-05-11 17:47:14 UTC) #4
pkx166h
Nearly there I hope. Third draft. James http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/5001/Documentation/notation/staff.itely#newcode1090 Documentation/notation/staff.itely:1090: The @code{\transposition} ...
8 years ago (2011-05-12 12:24:22 UTC) #5
Graham Percival (old account)
LGTM http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely#newcode1144 Documentation/notation/staff.itely:1144: Quotes can also be tagged see @ref{Using tags}. ...
8 years ago (2011-05-12 13:35:03 UTC) #6
pkx166h
Number 4. James http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/1002/Documentation/notation/staff.itely#newcode1144 Documentation/notation/staff.itely:1144: Quotes can also be tagged see ...
8 years ago (2011-05-12 15:20:55 UTC) #7
Graham Percival (old account)
On 2011/05/12 15:20:55, J_lowe wrote: > Number 4. oops, I didn't mean that you had ...
8 years ago (2011-05-12 16:41:07 UTC) #8
Trevor Daniels
http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely#newcode1044 Documentation/notation/staff.itely:1044: quotation begins. It is followed by two arguments; the ...
8 years ago (2011-05-12 16:52:34 UTC) #9
Keith
http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely#newcode1092 Documentation/notation/staff.itely:1092: that have the same sounding pitch as those in ...
8 years ago (2011-05-12 17:41:10 UTC) #10
pkx166h
5th Draft http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4518053/diff/9002/Documentation/notation/staff.itely#newcode1044 Documentation/notation/staff.itely:1044: quotation begins. It is followed by two ...
8 years ago (2011-05-13 11:23:24 UTC) #11
pkx166h
Can I push? Trevor, do you still object to my last comment about that para? ...
8 years ago (2011-05-19 16:57:15 UTC) #12
t.daniels_treda.co.uk
pkx166h@gmail.com wrote Thursday, May 19, 2011 5:57 PM > Trevor, do you still object to ...
8 years ago (2011-05-20 07:52:22 UTC) #13
pkx166h
On 2011/05/20 07:52:22, t.daniels_treda.co.uk wrote: > mailto:pkx166h@gmail.com wrote Thursday, May 19, 2011 5:57 PM > ...
7 years, 12 months ago (2011-05-23 20:37:46 UTC) #14
pkx166h
6th Draft. James
7 years, 12 months ago (2011-05-23 20:38:30 UTC) #15
Keith
On 2011/05/23 20:38:30, J_lowe wrote: > 6th Draft. Still looks fine to me.
7 years, 12 months ago (2011-05-24 05:16:43 UTC) #16
t.daniels_treda.co.uk
<pkx166h@gmail.com> wrote Monday, May 23, 2011 9:37 PM > I've made a change to the ...
7 years, 12 months ago (2011-05-24 08:34:42 UTC) #17
Graham Percival (old account)
On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: > > I think it is worth adding Music classes ...
7 years, 12 months ago (2011-05-24 09:14:59 UTC) #18
t.daniels_treda.co.uk
percival.music.ca@gmail.com wrote Tuesday, May 24, 2011 10:14 AM > On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: > ...
7 years, 12 months ago (2011-05-24 09:52:51 UTC) #19
Graham Percival
On Tue, May 24, 2011 at 10:52:56AM +0100, Trevor Daniels wrote: > percival.music.ca@gmail.com wrote Tuesday, ...
7 years, 12 months ago (2011-05-24 12:00:47 UTC) #20
pkx166h
7 years, 12 months ago (2011-05-24 18:03:32 UTC) #21
Thanks everyone

Pushed

c7edeb3d1c298262efc6c077a3f6d2d62e072a96
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b