Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(267)

Issue 4518052: Fattens the 256 first braces. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by Bertrand Bordage
Modified:
7 years, 11 months ago
Reviewers:
pacovila, dak, carl.d.sorensen, Trevor Daniels, Janek Warchol
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fattens the 256 first braces.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Save variables #

Total comments: 4

Patch Set 3 : Cleans function (thanks to dak) #

Patch Set 4 : Cleans code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M mf/feta-braces.mf View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 14
Carl
LGTM, with a small nitpick. I like the new braces better. Carl http://codereview.appspot.com/4518052/diff/1/mf/feta-braces.mf File mf/feta-braces.mf ...
8 years, 1 month ago (2011-05-10 19:51:20 UTC) #1
Bertrand Bordage
Thanks for the review ! Patch updated. I don't know if there's a better way ...
8 years, 1 month ago (2011-05-10 20:08:03 UTC) #2
Trevor Daniels
LGTM, apart from one nitpick. I much prefer your redesigned braces! Trevor http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf File mf/feta-braces.mf ...
8 years, 1 month ago (2011-05-10 22:53:55 UTC) #3
Bertrand Bordage
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf File mf/feta-braces.mf (right): http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode150 mf/feta-braces.mf:150: save fatten; That's what I thought at first. Then ...
8 years, 1 month ago (2011-05-10 23:15:02 UTC) #4
dak
If you say you fatten the first 256 braces, does that mean that there is ...
8 years, 1 month ago (2011-05-11 07:42:33 UTC) #5
pacovila
2011/5/11 <dak@gnu.org>: > If you say you fatten the first 256 braces, does that mean ...
8 years, 1 month ago (2011-05-11 08:01:28 UTC) #6
pacovila
2011/5/11 Francisco Vila <paconet.org@gmail.com>: > 2011/5/11 <dak@gnu.org>: >> If you say you fatten the first ...
8 years, 1 month ago (2011-05-11 08:15:45 UTC) #7
Bertrand Bordage
I don't know if this is a joke, so I answer to David's question : ...
8 years, 1 month ago (2011-05-11 08:49:00 UTC) #8
dak
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf File mf/feta-braces.mf (right): http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode151 mf/feta-braces.mf:151: fatten := 1 + fatten_factor - min ( number ...
8 years, 1 month ago (2011-05-11 08:54:40 UTC) #9
Bertrand Bordage
http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf File mf/feta-braces.mf (right): http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode151 mf/feta-braces.mf:151: fatten := 1 + fatten_factor - min ( number ...
8 years, 1 month ago (2011-05-11 09:22:14 UTC) #10
dak
On 2011/05/11 09:22:14, Bertrand Bordage wrote: > http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf > File mf/feta-braces.mf (right): > > http://codereview.appspot.com/4518052/diff/2002/mf/feta-braces.mf#newcode151 ...
8 years, 1 month ago (2011-05-11 09:54:36 UTC) #11
dak
On 2011/05/11 09:54:36, dak wrote: > Something like > fatten := min(number/256,1)[1+fatten_factor,1]; > should do ...
8 years, 1 month ago (2011-05-11 10:04:52 UTC) #12
Bertrand Bordage
:) Thanks ! This works great. Updated.
8 years, 1 month ago (2011-05-11 10:14:11 UTC) #13
Janek Warchol
8 years, 1 month ago (2011-05-11 11:32:15 UTC) #14
LGTM.
I like the results!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b