Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(792)

Issue 45180043: code review 45180043: runtime/cgo: always set signal mask before calling pthr... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by iant
Modified:
7 years, 11 months ago
Reviewers:
dfc
CC:
golang-codereviews, dfc
Visibility:
Public.

Description

runtime/cgo: always set signal mask before calling pthread_create This was done correctly for most targets but was missing from FreeBSD/ARM and Linux/ARM.

Patch Set 1 #

Total comments: 3

Patch Set 2 : diff -r 2055f3fe92ff https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M src/pkg/runtime/cgo/gcc_freebsd_arm.c View 2 chunks +7 lines, -0 lines 0 comments Download
M src/pkg/runtime/cgo/gcc_linux_arm.c View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5
iant
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
7 years, 11 months ago (2013-12-24 04:32:13 UTC) #1
dfc
LGTM. This might explain why the Linux/arm builder has been flakey recently. > On 24 ...
7 years, 11 months ago (2013-12-24 04:38:56 UTC) #2
dfc
https://codereview.appspot.com/45180043/diff/1/src/pkg/runtime/cgo/gcc_freebsd_arm.c File src/pkg/runtime/cgo/gcc_freebsd_arm.c (right): https://codereview.appspot.com/45180043/diff/1/src/pkg/runtime/cgo/gcc_freebsd_arm.c#newcode60 src/pkg/runtime/cgo/gcc_freebsd_arm.c:60: pthread_sigmask(SIG_SETMASK, &oset, nil); should this go below the check ...
7 years, 11 months ago (2013-12-24 06:08:10 UTC) #3
iant
https://codereview.appspot.com/45180043/diff/1/src/pkg/runtime/cgo/gcc_freebsd_arm.c File src/pkg/runtime/cgo/gcc_freebsd_arm.c (right): https://codereview.appspot.com/45180043/diff/1/src/pkg/runtime/cgo/gcc_freebsd_arm.c#newcode60 src/pkg/runtime/cgo/gcc_freebsd_arm.c:60: pthread_sigmask(SIG_SETMASK, &oset, nil); On 2013/12/24 06:08:10, dfc wrote: > ...
7 years, 11 months ago (2013-12-24 16:07:56 UTC) #4
iant
7 years, 11 months ago (2013-12-24 16:08:23 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=15deca59be01 ***

runtime/cgo: always set signal mask before calling pthread_create

This was done correctly for most targets but was missing from
FreeBSD/ARM and Linux/ARM.

R=golang-codereviews, dave
CC=golang-codereviews
https://codereview.appspot.com/45180043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b