Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1234)

Issue 4517060: code review 4517060: misc/vim: improved indent script

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Ross Light
Modified:
12 years, 11 months ago
Reviewers:
mattn, dsymonds, golang-dev
CC:
golang-dev, rivercheng_gmail.com, dsymonds
Visibility:
Public.

Description

misc/vim: improved indent script

Patch Set 1 #

Patch Set 2 : diff -r 740b18a25fcf44fd9aed231ab253375ebf0cfb1b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 740b18a25fcf44fd9aed231ab253375ebf0cfb1b https://go.googlecode.com/hg/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -17 lines) Patch
A misc/vim/ftplugin/go/comments.vim View 1 1 chunk +10 lines, -0 lines 0 comments Download
M misc/vim/indent/go.vim View 1 1 chunk +86 lines, -17 lines 1 comment Download

Messages

Total messages: 5
Ross Light
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 11 months ago (2011-05-13 01:57:20 UTC) #1
dsymonds
Erm, check out my http://codereview.appspot.com/4534047/ that I sent out a couple of days ago.
12 years, 11 months ago (2011-05-13 02:10:50 UTC) #2
Ross Light
On 2011/05/13 02:10:50, dsymonds wrote: > Erm, check out my http://codereview.appspot.com/4534047/ that I sent > ...
12 years, 11 months ago (2011-05-13 02:15:36 UTC) #3
dsymonds
On Thu, May 12, 2011 at 7:15 PM, <rlight2@gmail.com> wrote: > Whoops! Must have missed ...
12 years, 11 months ago (2011-05-13 02:21:55 UTC) #4
mattn
12 years, 11 months ago (2011-05-13 02:35:04 UTC) #5
http://codereview.appspot.com/4517060/diff/4003/misc/vim/indent/go.vim
File misc/vim/indent/go.vim (right):

http://codereview.appspot.com/4517060/diff/4003/misc/vim/indent/go.vim#newcode62
misc/vim/indent/go.vim:62: 
Have better to add checking multi-line string like below.

   foo := `
bar
`

add following into this point.
---------------------
    if synIDattr(synID(a:lnum, 1, 1), "name") == 'goRawString'
        return 0
    endif
---------------------
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b