Move Domita tests to ES53

Port Domita tests to ES53.

The changes to Domita make parts of it fail under Valija/Cajita, so this change @FailureIsAnOption-s the Domita tests rather than trying to keep them running.

[ihab.awad, 2011-05-18 15:22:22]

Fyi --

On Wed, May 18, 2011 at 8:21 AM, <ihab.awad@gmail.com> wrote:

> This is a provisional change that moves the Domita tests to ES53. It
> is fairly ambitious in attempting to do all of them in one big CL. We
> may or may not proceed with this approach.
>

As noted, this is provisional; for discussion only. Not ready for review.

Ihab

[ihab.awad, 2011-06-04 18:55:25]

Ready to start review.

[ihab.awad, 2011-06-07 17:07:44]

Reassigning reviewers, thanks Mike and Felix for voluteering!

[metaweta, 2011-06-07 23:05:40]

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/parser/q...
File src/com/google/caja/parser/quasiliteral/opt/ArrayIndexOptimization.java
(right):

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/parser/q...
src/com/google/caja/parser/quasiliteral/opt/ArrayIndexOptimization.java:111:
System.err.println("About to optimize: " + render(root, false));
cruft

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:126: function hasGetHandler(object,
propertyName) {
You want this code:
return !!this[name + '_getter___'];

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:131: function hasSetHandler(object,
propertyName) {
You want code similar to above, but using _setter___.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:136: function hasCallHandler(object,
propertyName) {
Ditto, _handler___

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:141: function hasDeleteHandler(object,
propertyName) {
Ditto, _deleter___

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:266: this[name + '_e___'] = true;
Should be
this[name + '_e___'] = this;

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:272: if (___.isFrozen(this)) { throw new
Error(FROZEN); }
Object.isFrozen

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:1814: this[name + '_e___'] = true;
again, set to this, not true

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:2008: this[name + '_e___'] = true;
again

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:3707: this[name + '_e___'] = true;
again

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:4347: href:
String(optPseudoWindowLocation.href || 'http://nosuchhost.fake:80/'),
line length

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:4548: this[name + '_e___'] = true;
again

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/browser-test-case.js (right):

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/browser-test-case.js:422:
standardImports.assertColor =
frameGroup.tame(frameGroup.markFunction(function(expected, cssColorString) {
line length

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/es53-test-domita-canvas-guest.html (right):

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/es53-test-domita-canvas-guest.html:52:
assertUndefined('getContext with unapproved contextId',
canvas.getContext("foo"));
Line length (and several more below)

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/es53-test-domita-dom-guest.html (right):

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/es53-test-domita-dom-guest.html:92: //
TODO(mikesamuel): enable for all node-types once EQ fixed on IE
Annoying line lengths

[ihab.awad, 2011-06-14 22:51:00]

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/parser/q...
File src/com/google/caja/parser/quasiliteral/opt/ArrayIndexOptimization.java
(right):

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/parser/q...
src/com/google/caja/parser/quasiliteral/opt/ArrayIndexOptimization.java:111:
System.err.println("About to optimize: " + render(root, false));
On 2011/06/07 23:05:40, metaweta wrote:
> cruft

Done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
File src/com/google/caja/plugin/domita.js (right):

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:126: function hasGetHandler(object,
propertyName) {
On 2011/06/07 23:05:40, metaweta wrote:
> You want this code:
> return !!this[name + '_getter___'];

Actually _g___, done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:131: function hasSetHandler(object,
propertyName) {
On 2011/06/07 23:05:40, metaweta wrote:
> You want code similar to above, but using _setter___.

Actually _s___, done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:136: function hasCallHandler(object,
propertyName) {
On 2011/06/07 23:05:40, metaweta wrote:
> Ditto, _handler___

Unused function, removed.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:141: function hasDeleteHandler(object,
propertyName) {
On 2011/06/07 23:05:40, metaweta wrote:
> Ditto, _deleter___

Unused function, removed.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:266: this[name + '_e___'] = true;
On 2011/06/07 23:05:40, metaweta wrote:
> Should be
> this[name + '_e___'] = this;

Done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:272: if (___.isFrozen(this)) { throw new
Error(FROZEN); }
On 2011/06/07 23:05:40, metaweta wrote:
> Object.isFrozen

Done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:1814: this[name + '_e___'] = true;
On 2011/06/07 23:05:40, metaweta wrote:
> again, set to this, not true

Done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:2008: this[name + '_e___'] = true;
On 2011/06/07 23:05:40, metaweta wrote:
> again

Done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:3707: this[name + '_e___'] = true;
On 2011/06/07 23:05:40, metaweta wrote:
> again

Done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:4347: href:
String(optPseudoWindowLocation.href || 'http://nosuchhost.fake:80/'),
On 2011/06/07 23:05:40, metaweta wrote:
> line length

Done.

http://codereview.appspot.com/4515107/diff/17022/src/com/google/caja/plugin/d...
src/com/google/caja/plugin/domita.js:4548: this[name + '_e___'] = true;
On 2011/06/07 23:05:40, metaweta wrote:
> again

Done.

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/browser-test-case.js (right):

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/browser-test-case.js:422:
standardImports.assertColor =
frameGroup.tame(frameGroup.markFunction(function(expected, cssColorString) {
On 2011/06/07 23:05:40, metaweta wrote:
> line length

Done.

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/es53-test-domita-canvas-guest.html (right):

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/es53-test-domita-canvas-guest.html:52:
assertUndefined('getContext with unapproved contextId',
canvas.getContext("foo"));
On 2011/06/07 23:05:40, metaweta wrote:
> Line length (and several more below)

Done.

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
File tests/com/google/caja/plugin/es53-test-domita-dom-guest.html (right):

http://codereview.appspot.com/4515107/diff/17022/tests/com/google/caja/plugin...
tests/com/google/caja/plugin/es53-test-domita-dom-guest.html:92: //
TODO(mikesamuel): enable for all node-types once EQ fixed on IE
On 2011/06/07 23:05:40, metaweta wrote:
> Annoying line lengths

Done.

[metaweta, 2011-06-15 19:30:11]

lgtm

[ihab.awad, 2011-06-16 19:29:17]

@4506