Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 45150045: code review 45150045: os,syscall: use ReadFile/MultiByteToWideChar to read fr...

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by mattn
Modified:
6 years, 1 month ago
Reviewers:
CC:
golang-codereviews, gobot, brainman, minux1, rsc, peterGo
Visibility:
Public.

Description

os,syscall: use ReadFile/MultiByteToWideChar to read from console

Patch Set 1 #

Patch Set 2 : diff -r 7e1a4e190b02 http://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 7e1a4e190b02 http://go.googlecode.com/hg/ #

Patch Set 4 : diff -r f96d3354edb6 http://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -23 lines) Patch
M src/pkg/os/file_windows.go View 1 2 3 2 chunks +30 lines, -14 lines 0 comments Download
M src/pkg/syscall/syscall_windows.go View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 2 chunks +19 lines, -4 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 2 chunks +19 lines, -4 lines 0 comments Download

Messages

Total messages: 24
mattn
Hello golang-dev@googlegroups.com, I'd like you to review this change to http://go.googlecode.com/hg/
7 years ago (2013-12-24 00:30:46 UTC) #1
gobot
Replacing golang-dev with golang-codereviews. To the author of this CL: If you are using 'hg ...
7 years ago (2013-12-24 00:33:31 UTC) #2
gobot
R=alex.brainman@gmail.com (assigned by mattn.jp@gmail.com)
7 years ago (2013-12-24 00:35:46 UTC) #3
minux1
On Dec 23, 2013 7:30 PM, <mattn.jp@gmail.com> wrote: > Description: > os,syscall: use ReadFile/MultiByteToWideChar to ...
7 years ago (2013-12-24 00:57:55 UTC) #4
mattn
On 2013/12/24 00:57:55, minux wrote: > On Dec 23, 2013 7:30 PM, <mailto:mattn.jp@gmail.com> wrote: > ...
7 years ago (2013-12-24 02:02:12 UTC) #5
brainman
Yes. It has been discussed before. And I am against this change, because I don't ...
7 years ago (2013-12-25 01:18:28 UTC) #6
mattn
> think issue 6303 is valid What is your reason? Why you had broken compatibility ...
7 years ago (2014-01-15 02:14:44 UTC) #7
brainman
On 2014/01/15 02:14:44, mattn wrote: > > think issue 6303 is valid > > What ...
7 years ago (2014-01-15 02:25:33 UTC) #8
mattn
On 2014/01/15 02:25:33, brainman wrote: > On 2014/01/15 02:14:44, mattn wrote: > > > think ...
7 years ago (2014-01-15 09:29:30 UTC) #9
mattn
ping
6 years, 11 months ago (2014-02-13 10:28:35 UTC) #10
rsc
I think this code looks good. It makes stdin reading more like a file and ...
6 years, 10 months ago (2014-03-05 20:06:11 UTC) #11
brainman
On 2014/03/05 20:06:11, rsc wrote: > ... It makes stdin reading more like a file ...
6 years, 10 months ago (2014-03-06 00:07:55 UTC) #12
brainman
On 2014/03/06 00:07:55, brainman wrote: > > ... Here are some I can think of: ...
6 years, 10 months ago (2014-03-06 00:27:31 UTC) #13
rsc
On Wed, Mar 5, 2014 at 7:07 PM, <alex.brainman@gmail.com> wrote: > On 2014/03/05 20:06:11, rsc ...
6 years, 10 months ago (2014-03-06 03:47:46 UTC) #14
brainman
On 2014/03/06 03:47:46, rsc wrote: > > We have three months of testing ahead of ...
6 years, 10 months ago (2014-03-06 05:58:57 UTC) #15
peterGo
Russ, On 2014/03/06 03:47:46, rsc wrote: > > Here's a different summary. ^Z is broken ...
6 years, 9 months ago (2014-04-21 11:50:45 UTC) #16
minux1
On Mon, Apr 21, 2014 at 7:50 AM, <go.peter.90@gmail.com> wrote: > Unfortunately the minimum requirements ...
6 years, 9 months ago (2014-04-21 17:31:54 UTC) #17
peterGo
Russ, On 2014/04/21 11:50:45, peterGo wrote: > Russ, > > The dwCtrlWakeupMask parameter of the ...
6 years, 9 months ago (2014-04-24 07:41:50 UTC) #18
peterGo
Russ, On 2014/03/06 03:47:46, rsc wrote: > > Here's a different summary. ^Z is broken ...
6 years, 8 months ago (2014-04-27 20:05:25 UTC) #19
peterGo
mattn, On 2013/12/24 02:02:12, mattn wrote: > Fixes issue #6303 After patching the Go tip ...
6 years, 8 months ago (2014-05-04 18:31:33 UTC) #20
mattn
2e591e82a8c8 seems not related on this issue? right? On 2014/05/04 18:31:33, peterGo wrote: > mattn, ...
6 years, 8 months ago (2014-05-07 06:52:08 UTC) #21
mattn
I updated patch. Windows can't read bytes over max of int16.
6 years, 8 months ago (2014-05-07 07:12:20 UTC) #22
mattn
ping
6 years, 7 months ago (2014-06-20 09:42:43 UTC) #23
gobot
6 years, 1 month ago (2014-12-19 05:17:58 UTC) #24
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/45150045 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b