Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(153)

Issue 95780046: code review 95780046: os,syscall: On Windows, recognize Control-Z for console...

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by peterGo
Modified:
6 years, 1 month ago
Reviewers:
CC:
golang-codereviews, minux1, rsc, mattn, brainman
Visibility:
Public.

Description

os,syscall: On Windows, recognize Control-Z for console input Package os provides a platform-independent interface to operating system functionality. The os interface is intended to be uniform across all operating systems. On Windows, Control-Z is equivalent to Control-D on Linux. Also, fix syscall Windows API parameter errors. Fixes issue 6303.

Patch Set 1 #

Patch Set 2 : diff -r 22dd1c22fd76 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 22dd1c22fd76 https://code.google.com/p/go/ #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -38 lines) Patch
M src/pkg/os/file_windows.go View 1 2 chunks +107 lines, -28 lines 1 comment Download
M src/pkg/syscall/syscall_windows.go View 1 3 chunks +5 lines, -4 lines 3 comments Download
M src/pkg/syscall/zsyscall_windows_386.go View 1 5 chunks +16 lines, -3 lines 0 comments Download
M src/pkg/syscall/zsyscall_windows_amd64.go View 1 5 chunks +16 lines, -3 lines 0 comments Download
M src/pkg/syscall/ztypes_windows.go View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5
peterGo
Hello golang-codereviews@googlegroups.com (cc: alex.brainman@gmail.com, mattn.jp@gmail.com, rsc@golang.org), I'd like you to review this change to https://code.google.com/p/go/
6 years, 8 months ago (2014-04-27 20:04:32 UTC) #1
peterGo
On 2014/04/27 20:04:32, peterGo wrote: > Hello mailto:golang-codereviews@googlegroups.com (cc: mailto:alex.brainman@gmail.com, > mailto:mattn.jp@gmail.com, mailto:rsc@golang.org), > > ...
6 years, 8 months ago (2014-04-27 20:10:04 UTC) #2
minux1
API changes are too late for Go 1.3. Sorry. (issue 6303 is not marked Go1.3 ...
6 years, 8 months ago (2014-04-27 20:13:59 UTC) #3
brainman
6 years, 8 months ago (2014-04-28 23:48:39 UTC) #4
gobot
6 years, 1 month ago (2014-12-19 05:19:15 UTC) #5
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/95780046 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b