Issue 44880044: code review 44880044: testing: document that ResetTimer also zeros the alloca...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 44880044: code review 44880044: testing: document that ResetTimer also zeros the alloca... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by minux1

Modified:
11 years, 6 months ago

Reviewers:
r

CC:
golang-codereviews, gobot, r

Visibility:
Public.

Description

testing: document that ResetTimer also zeros the allocation counters. Fixes issue 6998.

Patch Set 2 : diff -r c4b7c0824984 https://code.google.com/p/go #

Patch Set 3 : diff -r c4b7c0824984 https://code.google.com/p/go #

Total comments: 1

Patch Set 4 : diff -r f1e918132139 https://code.google.com/p/go #

Patch Set 5 : diff -r f1e918132139 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/testing/benchmark.go	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

minux1

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-12-21 19:18:01 UTC) #1

LGTM after tweak https://codereview.appspot.com/44880044/diff/40001/src/pkg/testing/benchmark.go File src/pkg/testing/benchmark.go (right): https://codereview.appspot.com/44880044/diff/40001/src/pkg/testing/benchmark.go#newcode78 src/pkg/testing/benchmark.go:78: // memory allocation counters. // ResetTimer ...

11 years, 6 months ago (2013-12-23 18:00:24 UTC) #3

minux1

11 years, 6 months ago (2014-01-09 20:21:28 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=88c69c34dceb ***

testing: document that ResetTimer also zeros the allocation counters.
Fixes issue 6998.

R=golang-codereviews, gobot, r
CC=golang-codereviews
https://codereview.appspot.com/44880044

Expand All Messages | Collapse All Messages