code review 44790043: os: reimplement HasPrefix and LastIndex to not depend ...

os: reimplement HasPrefix and LastIndex to not depend on strings

[0intro, 2013-12-20 23:41:37]

Hello golang-codereviews@googlegroups.com (cc: jas@corpus-callosum.com),

I'd like you to review this change to
https://code.google.com/p/go

[rsc, 2013-12-20 23:48:29]

https://codereview.appspot.com/44790043/diff/40001/src/pkg/os/file_plan9.go
File src/pkg/os/file_plan9.go (right):

https://codereview.appspot.com/44790043/diff/40001/src/pkg/os/file_plan9.go#n...
src/pkg/os/file_plan9.go:322: func lastIndex(s, sep string) int {
i believe lastindex is only ever used with a single byte separator. make it
lastIndex(s string, sep byte) and then just do the short for loop.

[0intro, 2013-12-20 23:56:48]

https://codereview.appspot.com/44790043/diff/40001/src/pkg/os/file_plan9.go
File src/pkg/os/file_plan9.go (right):

https://codereview.appspot.com/44790043/diff/40001/src/pkg/os/file_plan9.go#n...
src/pkg/os/file_plan9.go:322: func lastIndex(s, sep string) int {
On 2013/12/20 23:48:30, rsc wrote:
> i believe lastindex is only ever used with a single byte separator. make it
> lastIndex(s string, sep byte) and then just do the short for loop.

Done.

[rsc, 2013-12-21 00:20:21]

LGTM

[0intro, 2013-12-21 00:22:14]

*** Submitted as https://code.google.com/p/go/source/detail?r=5df3e8535335 ***

os: reimplement HasPrefix and LastIndex to not depend on strings

R=golang-codereviews, rsc
CC=golang-codereviews, jas
https://codereview.appspot.com/44790043