Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 44680043: code review 44680043: sync: explain Pool's intentions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by r
Modified:
3 years, 9 months ago
Reviewers:
rsc
CC:
golang-codereviews, gobot, rsc
Visibility:
Public.

Description

sync: explain Pool's intentions Expand the type's doc comment to make its purpose clear and discourage misuse.

Patch Set 1 #

Patch Set 2 : diff -r fdfc321546e7 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 3 : diff -r fdfc321546e7 https://code.google.com/p/go/ #

Patch Set 4 : diff -r fdfc321546e7 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 3ac4abe0c760 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M src/pkg/sync/pool.go View 1 2 3 4 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 6
r
Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
3 years, 9 months ago (2013-12-20 18:02:05 UTC) #1
gobot
R=rsc@golang.org (assigned by r@golang.org)
3 years, 9 months ago (2013-12-20 18:06:05 UTC) #2
rsc
https://codereview.appspot.com/44680043/diff/20001/src/pkg/sync/pool.go File src/pkg/sync/pool.go (right): https://codereview.appspot.com/44680043/diff/20001/src/pkg/sync/pool.go#newcode17 src/pkg/sync/pool.go:17: // Pool is not intended for general-purpose free lists. ...
3 years, 9 months ago (2013-12-20 18:13:46 UTC) #3
r
Hello golang-codereviews@googlegroups.com, gobot@golang.org, rsc@golang.org (cc: golang-codereviews@googlegroups.com), Please take another look.
3 years, 9 months ago (2013-12-20 18:33:35 UTC) #4
rsc
LGTM https://codereview.appspot.com/44680043/diff/60001/src/pkg/sync/pool.go File src/pkg/sync/pool.go (right): https://codereview.appspot.com/44680043/diff/60001/src/pkg/sync/pool.go#newcode20 src/pkg/sync/pool.go:20: // entries from the pool when it makes ...
3 years, 9 months ago (2013-12-20 19:09:51 UTC) #5
r
3 years, 9 months ago (2013-12-20 19:15:53 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=d9681a334cc4 ***

sync: explain Pool's intentions
Expand the type's doc comment to make its purpose clear
and discourage misuse.

R=golang-codereviews, gobot, rsc
CC=golang-codereviews
https://codereview.appspot.com/44680043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted