Update 2.4.1 CHANGES.txt

[Jisi Liu, 2011-04-29 02:54:53]

Hi Wenbo and Jason,

Could you please take a look at the change log to see if there's wording/grammar
mistakes..?

Thanks!

[Wenbo, 2011-04-29 05:40:56]

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt
File CHANGES.txt (right):

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt#newcode4
CHANGES.txt:4: * Fixed the frendship problem for old compilers to make the
library now gcc 3
s/frendship/friends/

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt#newcode9
CHANGES.txt:9: * Fixed some JDK 1.6 exclusive usages to make the library now JDK
1.5
I think @Override is the only JDK 5->6 compatibility issue. So you may just
spell it out directly.

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt#newcode12
CHANGES.txt:12: * serialVersionUID is now defined in generated messages for java
serializing.
OK, I should have asked you earlier. Why we need Java serialization support for
protobuf auto-gen classes? We might considering Externalizable in future though.

[Jisi Liu, 2011-04-29 05:55:54]

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt
File CHANGES.txt (right):

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt#newcode9
CHANGES.txt:9: * Fixed some JDK 1.6 exclusive usages to make the library now JDK
1.5
On 2011/04/29 05:40:56, Wenbo wrote:
> I think @Override is the only JDK 5->6 compatibility issue. So you may just
> spell it out directly.

Actually there's another AbstractMap.SimpleEntry usage in our code which is
public in JDK 6 but private in JDK 5.. The fix is to manually implement it in
our code. See http://codereview.appspot.com/4446069/patch/5001/6002

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt#newcode12
CHANGES.txt:12: * serialVersionUID is now defined in generated messages for java
serializing.
On 2011/04/29 05:40:56, Wenbo wrote:
> OK, I should have asked you earlier. Why we need Java serialization support
for
> protobuf auto-gen classes? We might considering Externalizable in future
though.
> 

This was added in cl/14644920. There might be some usages for this internally..

[Wenbo, 2011-04-29 06:20:11]

LG.

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt
File CHANGES.txt (right):

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt#newcode9
CHANGES.txt:9: * Fixed some JDK 1.6 exclusive usages to make the library now JDK
1.5
On 2011/04/29 05:55:54, Pherl Liu wrote:
> On 2011/04/29 05:40:56, Wenbo wrote:
> > I think @Override is the only JDK 5->6 compatibility issue. So you may just
> > spell it out directly.
> 
> Actually there's another AbstractMap.SimpleEntry usage in our code which is
> public in JDK 6 but private in JDK 5.. The fix is to manually implement it in
> our code. See http://codereview.appspot.com/4446069/patch/5001/6002

OK. 

"Removed usages of JDK 1.6 only features to ..."

http://codereview.appspot.com/4444077/diff/1/CHANGES.txt#newcode12
CHANGES.txt:12: * serialVersionUID is now defined in generated messages for java
serializing.
On 2011/04/29 05:55:54, Pherl Liu wrote:
> On 2011/04/29 05:40:56, Wenbo wrote:
> > OK, I should have asked you earlier. Why we need Java serialization support
> for
> > protobuf auto-gen classes? We might considering Externalizable in future
> though.
> > 
> 
> This was added in cl/14644920. There might be some usages for this
internally.. 
OK .. as chatted offline.