gdata-py Adding Spreadsheets cells and list feeds to v2 client.

[jcgregorio_google, 2011-05-22 05:05:05]

Sorry about taking so long to review.  -joe

http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l...
File tests/gdata_tests/spreadsheets/live_client_test.py (right):

http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l...
tests/gdata_tests/spreadsheets/live_client_test.py:160: test_worksheet =
self.client.add_worksheet(
Will this fail if the worksheet already exists? If so then accommodate that
condition and continue with the test.

http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l...
tests/gdata_tests/spreadsheets/live_client_test.py:194: test_worksheet =
self.client.add_worksheet(
Same as above comment if the sheet already exists.

http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l...
tests/gdata_tests/spreadsheets/live_client_test.py:210: # Update the row.
maybe just remember the # of rows and that they decrease, instead of explicitly
checking for 1 and 0.

[j.s, 2011-06-10 01:04:17]

http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l...
File tests/gdata_tests/spreadsheets/live_client_test.py (right):

http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l...
tests/gdata_tests/spreadsheets/live_client_test.py:160: test_worksheet =
self.client.add_worksheet(
On 2011/05/22 05:05:05, jcgregorio_google wrote:
> Will this fail if the worksheet already exists? If so then accommodate that
> condition and continue with the test.

No failure, it is possible to have worksheets with the same name. It won't cause
a problem since we operate on worksheet ID.

http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l...
tests/gdata_tests/spreadsheets/live_client_test.py:194: test_worksheet =
self.client.add_worksheet(
On 2011/05/22 05:05:05, jcgregorio_google wrote:
> Same as above comment if the sheet already exists.

Same as above, no issue.

http://codereview.appspot.com/4439066/diff/1/tests/gdata_tests/spreadsheets/l...
tests/gdata_tests/spreadsheets/live_client_test.py:210: # Update the row.
On 2011/05/22 05:05:05, jcgregorio_google wrote:
> maybe just remember the # of rows and that they decrease, instead of
explicitly
> checking for 1 and 0.

Since we create a new worksheet, I think checking for 0 and 1 would be more
accurate.

[jcgregorio_google, 2011-06-10 02:27:14]

LGTM