Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(446)

Issue 4438092: Better approach to fixing the TabVoice glissando problem. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by MikeSol
Modified:
8 years ago
Reviewers:
mike, Neil Puttock, c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Better approach to fixing the TabVoice glissando problem.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lily/tab-note-heads-engraver.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11
MikeSol
A better approach to the TabVoice glissando problem, although I'm still not quite sure why ...
8 years ago (2011-05-03 03:56:15 UTC) #1
Neil Puttock
On 2011/05/03 03:56:15, MikeSol wrote: > A better approach to the TabVoice glissando problem, although ...
8 years ago (2011-05-03 21:14:02 UTC) #2
mike_apollinemike.com
On May 3, 2011, at 2:14 PM, n.puttock@gmail.com wrote: > On 2011/05/03 03:56:15, MikeSol wrote: ...
8 years ago (2011-05-03 22:27:47 UTC) #3
Neil Puttock
On 2011/05/03 21:14:02, Neil Puttock wrote: > (reverse string-fret-fingering-tuples)) ;; end of determine-frets-and-strings Hmm, this ...
8 years ago (2011-05-03 22:30:11 UTC) #4
Neil Puttock
On 3 May 2011 23:27, mike@apollinemike.com <mike@apollinemike.com> wrote: > On May 3, 2011, at 2:14 ...
8 years ago (2011-05-03 22:36:08 UTC) #5
mike_apollinemike.com
On May 3, 2011, at 3:36 PM, Neil Puttock wrote: > On 3 May 2011 ...
8 years ago (2011-05-03 22:39:46 UTC) #6
mike_apollinemike.com
On May 3, 2011, at 3:39 PM, mike@apollinemike.com wrote: > On May 3, 2011, at ...
8 years ago (2011-05-03 22:44:53 UTC) #7
Neil Puttock
On 3 May 2011 23:44, mike@apollinemike.com <mike@apollinemike.com> wrote: > Back to http://codereview.appspot.com/4438092/, it seems as ...
8 years ago (2011-05-04 08:49:43 UTC) #8
mike_apollinemike.com
On May 4, 2011, at 1:49 AM, Neil Puttock wrote: > On 3 May 2011 ...
8 years ago (2011-05-06 14:52:45 UTC) #9
c_sorensen
On 5/6/11 8:52 AM, "mike@apollinemike.com" <mike@apollinemike.com> wrote: > On May 4, 2011, at 1:49 AM, ...
8 years ago (2011-05-06 15:59:06 UTC) #10
c_sorensen
8 years ago (2011-05-07 22:26:30 UTC) #11
On 5/6/11 8:52 AM, "mike@apollinemike.com" <mike@apollinemike.com> wrote:

> On May 4, 2011, at 1:49 AM, Neil Puttock wrote:
> 
>> On 3 May 2011 23:44, mike@apollinemike.com <mike@apollinemike.com> wrote:
>>> Back to http://codereview.appspot.com/4438092/, it seems as if this doesn't
>>> screw up the harmonics problem.
>> 
>> But they're already screwed (probably since the Tab_harmonic_engraver
>> was removed and the harmonics moved to the TabNoteHead print
>> function).
>> 
> 
> Carl - I know you're slammed w/ a paper, but do you have time to apply my
> patch (as well as the failed commit that I pushed to master), look into the
> TabNoteHead print function, and see if there's a more elegant way to do what
> I'm doing w/o messing up the harmonics?  I can put some time into it in a
> couple weeks, but I find that things go a lot quicker when the person who
> wrote a chunk of code sizes up the problem.


OK, I'm on this now.  The problem is that the procedure called to determine
frets and strings doesn't respect and maintain note ordering.  And the
ordering varies with whether or not strings are specified.  I've modified
the tablature-harmonics regtest to show the problem, and a fix will be
coming soon.

I think that will solve your problem.  Once I have tab harmonics
bulletproof, I'll check the glissando stuff out.

Thanks,

Carl

Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b