Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(680)

Issue 4437087: code review 4437087: net: add network interface identification API (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by mikio
Modified:
10 years, 6 months ago
CC:
r, gri, bradfitz, rh, rsc, golang-dev
Visibility:
Public.

Description

net: add network interface identification API This CL introduces new API into package net to identify the network interface. A functionality of new API is very similar to RFC3493 - "Interface Identification".

Patch Set 1 : diff -r 01b6a240e0b7 https://go.googlecode.com/hg/ #

Total comments: 8

Patch Set 2 : diff -r 8f4462cc4bdc https://go.googlecode.com/hg/ #

Total comments: 6

Patch Set 3 : diff -r 3b02534fe256 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 3b02534fe256 https://go.googlecode.com/hg/ #

Total comments: 18

Patch Set 5 : diff -r d857654eedd8 https://go.googlecode.com/hg/ #

Total comments: 20

Patch Set 6 : diff -r fa2bae213af8 https://go.googlecode.com/hg/ #

Total comments: 14

Patch Set 7 : diff -r 596c547538d6 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+565 lines, -0 lines) Patch
M src/pkg/net/Makefile View 5 chunks +6 lines, -0 lines 0 comments Download
A src/pkg/net/interface.go View 1 2 3 4 5 6 1 chunk +133 lines, -0 lines 0 comments Download
A src/pkg/net/interface_bsd.go View 1 2 3 4 5 1 chunk +148 lines, -0 lines 0 comments Download
A src/pkg/net/interface_linux.go View 1 2 3 4 5 1 chunk +165 lines, -0 lines 0 comments Download
A src/pkg/net/interface_stub.go View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A src/pkg/net/interface_test.go View 1 2 3 4 5 6 1 chunk +90 lines, -0 lines 0 comments Download

Messages

Total messages: 28
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
10 years, 6 months ago (2011-05-27 02:38:58 UTC) #1
r
a couple of small points in the portable code. http://codereview.appspot.com/4437087/diff/70036/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/70036/src/pkg/net/interface.go#newcode19 src/pkg/net/interface.go:19: ...
10 years, 6 months ago (2011-05-27 05:07:38 UTC) #2
mikio
http://codereview.appspot.com/4437087/diff/70036/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/70036/src/pkg/net/interface.go#newcode19 src/pkg/net/interface.go:19: if hwa == nil { On 2011/05/27 05:07:38, r ...
10 years, 6 months ago (2011-05-27 05:59:59 UTC) #3
mikio
Hello golang-dev@googlegroups.com, r@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2011-05-27 06:00:16 UTC) #4
gri
FYI. http://codereview.appspot.com/4437087/diff/83001/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/83001/src/pkg/net/interface.go#newcode23 src/pkg/net/interface.go:23: for i := 0; i < len(hwa); i++ ...
10 years, 6 months ago (2011-05-27 17:24:16 UTC) #5
mikio
http://codereview.appspot.com/4437087/diff/83001/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/83001/src/pkg/net/interface.go#newcode23 src/pkg/net/interface.go:23: for i := 0; i < len(hwa); i++ { ...
10 years, 6 months ago (2011-05-27 20:39:34 UTC) #6
mikio
Hello golang-dev@googlegroups.com, r@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2011-05-27 20:40:08 UTC) #7
mikio
Hello golang-dev@googlegroups.com, r@golang.org, gri@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2011-05-27 20:43:44 UTC) #8
gri
FYI. Leaving this to somebody who actually understands network interfaces. - gri http://codereview.appspot.com/4437087/diff/56040/src/pkg/net/interface_stub.go File src/pkg/net/interface_stub.go ...
10 years, 6 months ago (2011-05-27 21:47:12 UTC) #9
bradfitz
http://codereview.appspot.com/4437087/diff/56040/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/56040/src/pkg/net/interface.go#newcode35 src/pkg/net/interface.go:35: Name string e.g. "eth0" ? http://codereview.appspot.com/4437087/diff/56040/src/pkg/net/interface.go#newcode36 src/pkg/net/interface.go:36: Type string ...
10 years, 6 months ago (2011-05-27 21:54:44 UTC) #10
mikio
http://codereview.appspot.com/4437087/diff/56040/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/56040/src/pkg/net/interface.go#newcode35 src/pkg/net/interface.go:35: Name string On 2011/05/27 21:54:44, bradfitz wrote: > e.g. ...
10 years, 6 months ago (2011-05-29 05:39:48 UTC) #11
mikio
Hello golang-dev@googlegroups.com, r@golang.org, gri@golang.org, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2011-05-29 05:40:38 UTC) #12
mikio
Ping. On Sun, May 29, 2011 at 2:40 PM, <mikioh.mikioh@gmail.com> wrote: > Hello golang-dev@googlegroups.com, r@golang.org, ...
10 years, 6 months ago (2011-06-01 10:01:16 UTC) #13
rh
What about remove interface_stub? All OSes get interface_$(GOOS).go in Makefile. Plan 9 gets: func interfaceTable(ifindex ...
10 years, 6 months ago (2011-06-02 04:52:52 UTC) #14
mikio
On Thu, Jun 2, 2011 at 1:52 PM, <robert.hencke@gmail.com> wrote: > What about remove interface_stub? ...
10 years, 6 months ago (2011-06-02 05:55:37 UTC) #15
albert.strasheim
On 2011/05/27 02:38:58, mikioh wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...
10 years, 6 months ago (2011-06-02 09:42:55 UTC) #16
rsc
Looks good; main concern is just error handling. I am a little worried about overloading ...
10 years, 6 months ago (2011-06-02 15:13:32 UTC) #17
mikio
All done. http://codereview.appspot.com/4437087/diff/64044/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/64044/src/pkg/net/interface.go#newcode15 src/pkg/net/interface.go:15: // HardwareAddr represents the hardware address of ...
10 years, 6 months ago (2011-06-03 15:01:40 UTC) #18
mikio
Hello r@golang.org, gri@golang.org, bradfitz@golang.org, robert.hencke@gmail.com, fullung@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2011-06-03 15:02:05 UTC) #19
rsc
LGTM Please make the changes below and I'll submit it. http://codereview.appspot.com/4437087/diff/63059/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/63059/src/pkg/net/interface.go#newcode57 ...
10 years, 6 months ago (2011-06-03 16:50:07 UTC) #20
mikio
http://codereview.appspot.com/4437087/diff/63059/src/pkg/net/interface.go File src/pkg/net/interface.go (right): http://codereview.appspot.com/4437087/diff/63059/src/pkg/net/interface.go#newcode57 src/pkg/net/interface.go:57: // SupportsBroadcast returns true if ifi supports a broadcast ...
10 years, 6 months ago (2011-06-03 18:18:10 UTC) #21
mikio
Hello r@golang.org, gri@golang.org, bradfitz@golang.org, robert.hencke@gmail.com, fullung@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
10 years, 6 months ago (2011-06-03 18:18:27 UTC) #22
rsc
*** Submitted as http://code.google.com/p/go/source/detail?r=9f4046737460 *** net: add network interface identification API This CL introduces new ...
10 years, 6 months ago (2011-06-03 18:35:44 UTC) #23
albert.strasheim
Hello On 2011/06/03 18:35:44, rsc wrote: > *** Submitted as http://code.google.com/p/go/source/detail?r=9f4046737460 *** > net: add ...
10 years, 6 months ago (2011-06-08 15:32:55 UTC) #24
mikio
Hi, On Thu, Jun 9, 2011 at 12:32 AM, <fullung@gmail.com> wrote: > The rawFlags field ...
10 years, 6 months ago (2011-06-08 16:32:59 UTC) #25
albert.strasheim
Hello On Wed, Jun 8, 2011 at 6:32 PM, Mikio Hara <mikioh.mikioh@gmail.com> wrote: > Hi, ...
10 years, 6 months ago (2011-06-08 16:40:21 UTC) #26
kevlar
I see the following issue on two separate Linux amd_64 boxes at tip: http://code.google.com/p/go/issues/detail?id=1942 On ...
10 years, 6 months ago (2011-06-10 16:01:17 UTC) #27
mikio
10 years, 6 months ago (2011-06-10 22:01:32 UTC) #28
On Sat, Jun 11, 2011 at 1:00 AM, Kyle Lemons <kevlar@google.com> wrote:

> I see the following issue on two separate Linux amd_64 boxes at tip:
> http://code.google.com/p/go/issues/detail?id=1942

Thank you for the report and nice %q.
The issue will be fixed by CL 462044.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b