code review 4602044: net: export all fields in Interface

net: export all fields in Interface

Fixes issue 1942.

[mikio, 2011-06-08 16:49:04]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[mikio, 2011-06-10 00:21:58]

Hello golang-dev@googlegroups.com, fullung@gmail.com (cc:
golang-dev@googlegroups.com),

Please take another look.

[albert.strasheim, 2011-06-10 00:37:06]

LGTM. You might want to add a reviewer that can commit this.

On 2011/06/10 00:21:58, mikioh wrote:
> Hello mailto:golang-dev@googlegroups.com, mailto:fullung@gmail.com (cc:
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

[mikio, 2011-06-10 01:29:12]

Would you mind reviewing this CL please, Mr. Cox.

On Fri, Jun 10, 2011 at 9:37 AM,  <fullung@gmail.com> wrote:

> LGTM. You might want to add a reviewer that can commit this.
>
> On 2011/06/10 00:21:58, mikioh wrote:
>>
>> Hello mailto:golang-dev@googlegroups.com, mailto:fullung@gmail.com
>
> (cc:
>>
>> mailto:golang-dev@googlegroups.com),
>
>> Please take another look.
>
> http://codereview.appspot.com/4602044/

[mikio, 2011-06-10 01:44:36]

Hello golang-dev@googlegroups.com, fullung@gmail.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-06-10 21:59:02]

Hello golang-dev@googlegroups.com, fullung@gmail.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

Please take another look.

[mikio, 2011-06-14 00:15:33]

Ping.

On Sat, Jun 11, 2011 at 6:59 AM,  <mikioh.mikioh@gmail.com> wrote:

> Hello golang-dev@googlegroups.com, fullung@gmail.com, rsc@golang.org
> (cc: golang-dev@googlegroups.com),
>
> Please take another look.
>
>
> http://codereview.appspot.com/4602044/

[rsc, 2011-06-14 00:45:13]

On Mon, Jun 13, 2011 at 20:15, Mikio Hara <mikioh.mikioh@gmail.com> wrote:
> Ping.

I haven't forgotten this; I've just got a lot of things pending.  Hang in there.

[rsc, 2011-06-14 15:15:26]

http://codereview.appspot.com/4602044/diff/7018/src/pkg/net/interface.go
File src/pkg/net/interface.go (right):

http://codereview.appspot.com/4602044/diff/7018/src/pkg/net/interface.go#newc...
src/pkg/net/interface.go:45: flagMulticast    = 1 << 15
Are these defined by an RFC or something?
If so, please add a comment at the top of the block saying so.
If not, use 1<<iota

Also, is there a reason not to export the flags and throw away the methods?

type Flags uint

const (
    FlagUp Flags = 1<<iota
    FlagBroadcast
    FlagLoopback
    FlagPointToPoint
    FlagMulticast
)

var flagNames = []string {
    "up",
    "broadcast",
    "loopback",
    "pointtopoint",
    "multicast"
}

func (f Flags) String() string {
    s := ""
    for i, name := range flagNames {
        if f&(1<<i) != 0 {
            if s != "" {
                s += "|"
            }
            s += name
        }
    }
    if s == "" {
        s = "0"
    }
    return s
}

[rsc, 2011-06-14 15:16:29]

please change description to

net: export all fields in Interface

iterable is not a go concept

[mikio, 2011-06-14 16:57:08]

all done.

http://codereview.appspot.com/4602044/diff/7018/src/pkg/net/interface.go
File src/pkg/net/interface.go (right):

http://codereview.appspot.com/4602044/diff/7018/src/pkg/net/interface.go#newc...
src/pkg/net/interface.go:45: flagMulticast    = 1 << 15
On 2011/06/14 15:15:26, rsc wrote:
> Are these defined by an RFC or something?

nope.

> If so, please add a comment at the top of the block saying so.
> If not, use 1<<iota

ack.

> Also, is there a reason not to export the flags and throw away the methods?

no nothing special, i was trapped a fixed idea again. thx, will do so.

[mikio, 2011-06-14 16:57:25]

Hello fullung@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-06-14 17:12:24]

LGTM

http://codereview.appspot.com/4602044/diff/23012/src/pkg/net/interface.go
File src/pkg/net/interface.go (right):

http://codereview.appspot.com/4602044/diff/23012/src/pkg/net/interface.go#new...
src/pkg/net/interface.go:61: if f&(1<<Flags(i)) != 0 {
s/Flags/uint/

[mikio, 2011-06-14 17:24:49]

http://codereview.appspot.com/4602044/diff/23012/src/pkg/net/interface.go
File src/pkg/net/interface.go (right):

http://codereview.appspot.com/4602044/diff/23012/src/pkg/net/interface.go#new...
src/pkg/net/interface.go:61: if f&(1<<Flags(i)) != 0 {
On 2011/06/14 17:12:24, rsc wrote:
> s/Flags/uint/

Done.

[mikio, 2011-06-14 17:25:27]

Hello fullung@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc, 2011-06-14 17:32:56]

*** Submitted as http://code.google.com/p/go/source/detail?r=0648704168fb ***

net: export all fields in Interface

Fixes issue 1942.

R=fullung, rsc
CC=golang-dev
http://codereview.appspot.com/4602044

Committer: Russ Cox <rsc@golang.org>