Issue 4437076: code review 4437076: runtime: fix mkversion to output valid path separators

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4437076: code review 4437076: runtime: fix mkversion to output valid path separators

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by peterGo

Modified:
13 years ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime: fix mkversion to output valid path separators In a GOROOT path a backslash is a path separator not an escape character. For example, `C:\go`. Fixes gotest error: version.go:3: unknown escape sequence: g

Patch Set 1 #

Patch Set 2 : diff -r 9658399fdd33 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9658399fdd33 https://go.googlecode.com/hg/ #

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/mkversion.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

peterGo

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years ago (2011-04-27 18:30:38 UTC) #1

rsc

13 years ago (2011-04-27 19:47:14 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=a4ee5538faba ***

runtime: fix mkversion to output valid path separators

In a GOROOT path a backslash is a path separator
not an escape character. For example, `C:\go`.
Fixes gotest error:
version.go:3: unknown escape sequence: g

R=rsc
CC=golang-dev
http://codereview.appspot.com/4437076

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages