Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6583)

Issue 4437044: request builder podporuje aj textove properties v embObj (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by tomi.belan
Modified:
13 years ago
Reviewers:
ppershing, majak
CC:
fajr-devel+codereview_googlegroups.com
Base URL:
http://fajr.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -24 lines) Patch
M src/libfajr/window/RequestBuilderImpl.php View 1 chunk +25 lines, -24 lines 0 comments Download

Messages

Total messages: 5
tomi.belan
13 years ago (2011-04-16 17:20:25 UTC) #1
tomi.belan
(opraveny CC)
13 years ago (2011-04-16 18:08:43 UTC) #2
tomi.belan
(dalsi pokus o CC do fajr-devel mailinglistu)
13 years ago (2011-04-16 18:14:54 UTC) #3
majak
lgtm Ak by sa ti chcelo a mas napad ako, mozes kludne celu tuto metodu ...
13 years ago (2011-04-16 18:30:12 UTC) #4
ppershing
13 years ago (2011-04-16 18:32:41 UTC) #5
Hmm, zeby sme znbeuzili twig na requesty? Ako, nemusi byt zly napad ...

2011/4/16  <majak47@gmail.com>:
> lgtm
> Ak by sa ti chcelo a mas napad ako,
> mozes kludne celu tuto metodu prepisat tak,
> aby sa v nej dalo lepsie vyznat.
>
> Druha moznost, co ma napadla, je taka,
> ze my teoreticky vobec nepotrebujeme mat vseobecny generator AIS XML
> requestov.
> Mozno by nam stacilo, kebyze mame template pre kazdy request co robime a
> v nom len menime hodnoty.
> Vyhoda by bola taka, ze ked ideme spravit nejaku novu kominikaciu s
> AISom,
> tak sa velmi lahko bude robit novy XML request,
> lebo sa len prida nova sablona.
> tak sa velmi lah
>
> http://codereview.appspot.com/4437044/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b