Issue 4436045: bugfix pre whitescreen so zlym error reportingom v controllerInjectorovi.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4436045: bugfix pre whitescreen so zlym error reportingom v controllerInjectorovi. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by tomi.belan

Modified:
13 years ago

Reviewers:
ppershing

CC:
fajr-devel+codereview_googlegroups.com

Base URL:
http://fajr.googlecode.com/svn/trunk/

Visibility:
Public.

Description

bugfix pre whitescreen so zlym error reportingom v controllerInjectorovi.

Patch Set 2 : '' #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
M	src/Fajr.php	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/index.php	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/injection/Injector.php	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ppershing

lgtm, mozes zapracovat aj pripomienku http://codereview.appspot.com/4436045/diff/1/src/Fajr.php File src/Fajr.php (right): http://codereview.appspot.com/4436045/diff/1/src/Fajr.php#newcode295 src/Fajr.php:295: $this->config->get(FajrConfigOptions::DEBUG_EXCEPTION_SHOWSTACKTRACE) != true); hmm, ...

13 years ago (2011-04-18 14:41:50 UTC) #2

tomi.belan

http://codereview.appspot.com/4436045/diff/1/src/Fajr.php File src/Fajr.php (right): http://codereview.appspot.com/4436045/diff/1/src/Fajr.php#newcode295 src/Fajr.php:295: $this->config->get(FajrConfigOptions::DEBUG_EXCEPTION_SHOWSTACKTRACE) != true); On 2011/04/18 14:41:50, ppershing wrote: > ...

13 years ago (2011-04-18 15:55:23 UTC) #3

lgtm

Expand All Messages | Collapse All Messages