Issue 44230045: cmd/juju: upgrade-charm via the API + 1.16 compat

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 44230045: cmd/juju: upgrade-charm via the API + 1.16 compat (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by dimitern

Modified:
10 years, 4 months ago

Reviewers:
mp+199686, fwereade

Visibility:
Public.

Description

cmd/juju: upgrade-charm via the API + 1.16 compat This introduces one new API call: ServiceGetCharmURL, which is used by the upgrade-charm command to detect new or 1.16-compatible mode of execution (when the API server does not support the new API call, it's assumed 1.16 mode should be used). Also, now upgrade-juju does not use directly at all, and goes entirely through the API (except in 1.16 mode). https://code.launchpad.net/~dimitern/juju-core/228-cli-upgradecharm-via-api/+merge/199686 Requires: https://code.launchpad.net/~dimitern/juju-core/227-cli-deploy-via-api/+merge/199655 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : cmd/juju: upgrade-charm via the API + 1.16 compat #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+157 lines, -54 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/upgradecharm.go	View	1	5 chunks	+82 lines, -6 lines	0 comments	Download
M	cmd/juju/upgradecharm_test.go	View		4 chunks	+9 lines, -21 lines	0 comments	Download
M	state/api/client.go	View	1	1 chunk	+12 lines, -0 lines	0 comments	Download
M	state/api/params/params.go	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	state/apiserver/client/client.go	View	1	3 chunks	+24 lines, -16 lines	0 comments	Download
M	state/apiserver/client/client_test.go	View	1	2 chunks	+8 lines, -10 lines	0 comments	Download
M	state/apiserver/client/get.go	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	state/apiserver/client/get_test.go	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

fwereade

I don't love the singular ServiceGetCharmURL, but I guess it's consistent with existing practice. LGTM, ...

10 years, 4 months ago (2013-12-19 18:32:04 UTC) #2

dimitern

10 years, 4 months ago (2013-12-19 20:16:51 UTC) #3

Please take a look.

https://codereview.appspot.com/44230045/diff/1/cmd/juju/upgradecharm.go
File cmd/juju/upgradecharm.go (right):

https://codereview.appspot.com/44230045/diff/1/cmd/juju/upgradecharm.go#newco...
cmd/juju/upgradecharm.go:170: addedURL, err := addCharmViaAPI(client, newURL,
repo)
On 2013/12/19 18:32:04, fwereade wrote:
> Would be great if this func took a *cmd.Context, so it could output the exact
> charm URL it ended up using.

Done in the prereq and pulled here.

Expand All Messages | Collapse All Messages