Issue 44200043: environs/manual: ignore stderr in detection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 44200043: environs/manual: ignore stderr in detection

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 4 months ago by axw

Modified:
10 years, 4 months ago

Reviewers:
mp+199617, rog

Visibility:
Public.

Description

environs/manual: ignore stderr in detection SSH warnings were mucking up series/hw detection. https://code.launchpad.net/~axwalk/juju-core/environs-manual-detection-stderr/+merge/199617 (do not edit description out of merge proposal)

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	environs/manual/detection.go	View	1 chunk	+7 lines, -5 lines	0 comments	Download
M	environs/manual/detection_test.go	View	1 chunk	+15 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rog

On 2013/12/19 06:45:43, axw wrote: > Please take a look. LGTM assuming ssh really does ...

10 years, 4 months ago (2013-12-19 14:51:09 UTC) #2

axw

10 years, 4 months ago (2013-12-19 14:53:54 UTC) #3

On 2013/12/19 14:51:09, rog wrote:
> On 2013/12/19 06:45:43, axw wrote:
> > Please take a look.
> 
> LGTM assuming ssh really does use stdout and stderr correctly.

Yes, I've confirmed that by changing a key in ~/.ssh/known_hosts.

Expand All Messages | Collapse All Messages