Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(788)

Issue 44180043: code review 44180043: runtime/pprof: skip tests that fail on windows-amd64-ra... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by brainman
Modified:
11 years, 7 months ago
Reviewers:
bradfitz
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

runtime/pprof: skip tests that fail on windows-amd64-race builder

Patch Set 1 #

Patch Set 2 : diff -r 091d88caa24f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 091d88caa24f https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 30321941bac5 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/pkg/runtime/pprof/pprof_test.go View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4
brainman
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
11 years, 7 months ago (2013-12-19 03:12:05 UTC) #1
brainman
I really need to skip these for -race only. But I don't know how to ...
11 years, 7 months ago (2013-12-19 03:12:20 UTC) #2
bradfitz
LGTM On Wed, Dec 18, 2013 at 7:12 PM, <alex.brainman@gmail.com> wrote: > I really need ...
11 years, 7 months ago (2013-12-19 03:14:17 UTC) #3
brainman
11 years, 7 months ago (2013-12-19 03:16:04 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=302c3d2b8c1b ***

runtime/pprof: skip tests that fail on windows-amd64-race builder

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/44180043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b