Issue 4415045: Odstranene supporting_functions a presunute do classov

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4415045: Odstranene supporting_functions a presunute do classov (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by anty

Modified:
13 years ago

Reviewers:
ppershing

CC:
fajr-devel+codereview_googlegroups.com

Base URL:
http://fajr.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Odstranene supporting_functions a presunute do classov

Patch Set 1 #

Total comments: 1

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -165 lines)			Patch
M	src/libfajr/AIS2Utils.php	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	src/libfajr/connection/AIS2ErrorCheckingConnection.php	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/libfajr/data_manipulation/AIS2TableParser.php	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/libfajr/libfajr.php	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	src/libfajr/supporting_functions.php	View	1 chunk	+0 lines, -93 lines	0 comments	Download
A +	src/libfajr/util/MiscUtil.php	View	3 chunks	+7 lines, -61 lines	0 comments	Download
M	src/libfajr/util/StrUtil.php	View	1 chunk	+16 lines, -0 lines	1 comment	Download
M	src/libfajr/window/AIS2AbstractDialog.php	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/libfajr/window/VSES017_administracia_studia/AdministraciaStudiaScreenImpl.php	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/libfajr/window/VSES017_administracia_studia/TerminyDialogImpl.php	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/libfajr/window/VSES017_administracia_studia/TerminyHodnoteniaScreenImpl.php	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/libfajr/window/fake/FakeAbstractDialog.php	View	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ppershing

13 years ago (2011-04-15 06:17:12 UTC) #2

lgtm

http://codereview.appspot.com/4415045/diff/1/src/libfajr/util/StrUtil.php
File src/libfajr/util/StrUtil.php (right):

http://codereview.appspot.com/4415045/diff/1/src/libfajr/util/StrUtil.php#new...
src/libfajr/util/StrUtil.php:117: public static function utf8_sanitize($string)
mohli by sme spravit utf8Sanitize, a pridaj aj doccomment

Expand All Messages | Collapse All Messages