Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(9)

Issue 44150043: code review 44150043: regexp: use sync.Pool (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by bradfitz
Modified:
3 years ago
Reviewers:
rsc, dvyukov
CC:
golang-dev, rsc
Visibility:
Public.

Description

regexp: use sync.Pool For machines, not threads. Update Issue 4720

Patch Set 1 #

Patch Set 2 : diff -r 5002ec2f1082 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5002ec2f1082 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r afe351cefb6f https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M src/pkg/regexp/regexp.go View 1 3 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 12
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
3 years, 1 month ago (2013-12-19 00:08:15 UTC) #1
rsc
LGTM
3 years, 1 month ago (2013-12-19 00:35:54 UTC) #2
bradfitz
*** Submitted as https://code.google.com/p/go/source/detail?r=198bdc0984dd *** regexp: use sync.Pool For machines, not threads. Update Issue 4720 ...
3 years, 1 month ago (2013-12-19 00:43:22 UTC) #3
dvyukov
Wait, can this pool be made global now?
3 years, 1 month ago (2013-12-19 07:29:54 UTC) #4
rsc
On Thu, Dec 19, 2013 at 2:29 AM, <dvyukov@google.com> wrote: > Wait, can this pool ...
3 years, 1 month ago (2013-12-19 16:33:40 UTC) #5
bradfitz
On Thu, Dec 19, 2013 at 8:33 AM, Russ Cox <rsc@golang.org> wrote: > On Thu, ...
3 years, 1 month ago (2013-12-19 17:19:39 UTC) #6
dvyukov
On 2013/12/19 16:33:40, rsc wrote: > On Thu, Dec 19, 2013 at 2:29 AM, <mailto:dvyukov@google.com> ...
3 years, 1 month ago (2013-12-20 06:18:01 UTC) #7
rsc
On Fri, Dec 20, 2013 at 1:18 AM, <dvyukov@google.com> wrote: > On 2013/12/19 16:33:40, rsc ...
3 years ago (2014-01-06 18:38:23 UTC) #8
dvyukov
On Mon, Jan 6, 2014 at 10:38 PM, Russ Cox <rsc@golang.org> wrote: > On Fri, ...
3 years ago (2014-01-06 18:45:24 UTC) #9
bradfitz
On Mon, Jan 6, 2014 at 10:38 AM, Russ Cox <rsc@golang.org> wrote: > On Fri, ...
3 years ago (2014-01-06 18:49:25 UTC) #10
rsc
Let's just roll back this CL and end this discussion until there is an important ...
3 years ago (2014-01-06 20:34:05 UTC) #11
bradfitz
3 years ago (2014-01-06 20:34:41 UTC) #12
sure



On Mon, Jan 6, 2014 at 12:34 PM, Russ Cox <rsc@golang.org> wrote:

> Let's just roll back this CL and end this discussion until there is an
> important performance case to analyze.
>
> Thanks.
> Russ
>
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted