code review 44140043: liblink: use explicit field for globl duplicate detection

liblink: use explicit field for globl duplicate detection

Overloading size leads to problems if clients
try to set up an LSym by hand.

[rsc, 2013-12-19 00:01:55]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[bradfitz, 2013-12-19 00:35:35]

LGTM



On Wed, Dec 18, 2013 at 4:01 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> liblink: use explicit field for globl duplicate detection
>
> Overloading size leads to problems if clients
> try to set up an LSym by hand.
>
> Please review this at https://codereview.appspot.com/44140043/
>
> Affected files (+3, -1 lines):
>   M include/link.h
>   M src/liblink/objfile.c
>
>
> Index: include/link.h
> ===================================================================
> --- a/include/link.h
> +++ b/include/link.h
> @@ -131,6 +131,7 @@
>         uchar   hide;
>         uchar   leaf;   // arm only
>         uchar   fnptr;  // arm only
> +       uchar   seenglobl;
>         int16   symid;  // for writing .5/.6/.8 files
>         int32   dynid;
>         int32   sig;
> Index: src/liblink/objfile.c
> ===================================================================
> --- a/src/liblink/objfile.c
> +++ b/src/liblink/objfile.c
> @@ -167,7 +167,8 @@
>
>                         if(p->as == ctxt->arch->AGLOBL) {
>                                 s = p->from.sym;
> -                               if(s->size) print("duplicate %P\n", p);
> +                               if(s->seenglobl++)
> +                                       print("duplicate %P\n", p);
>                                 if(data == nil)
>                                         data = s;
>                                 else
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>

[rsc, 2013-12-19 00:36:18]

*** Submitted as https://code.google.com/p/go/source/detail?r=afe351cefb6f ***

liblink: use explicit field for globl duplicate detection

Overloading size leads to problems if clients
try to set up an LSym by hand.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/44140043