Issue 44070048: code review 44070048: re2: add dot_nl to the RE2::Options class

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 44070048: code review 44070048: re2: add dot_nl to the RE2::Options class

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by mpn

Modified:
11 years, 8 months ago

Reviewers:
rsc

CC:
rsc, re2-dev_googlegroups.com

Visibility:
Public.

Description

re2: add dot_nl to the RE2::Options class This allows clients to set the “s” flag by default for a given regular expression without the need to mess with the pattern by prefixing it with “(?s)”. This matters if the pattern comes from the user.

Patch Set 1 #

Patch Set 2 : diff -r 29591379d23a https://re2.googlecode.com/hg #

Patch Set 3 : diff -r 29591379d23a https://re2.googlecode.com/hg #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -1 line)			Patch
M	re2/re2.h	View	1	5 chunks	+8 lines, -1 line	0 comments	Download
M	re2/re2.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	re2/testing/re2_test.cc	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mpn

Hello rsc@golang.org (cc: re2-dev@googlegroups.com), I'd like you to review this change to https://re2.googlecode.com/hg

11 years, 9 months ago (2014-01-03 01:13:29 UTC) #1

rsc

11 years, 8 months ago (2014-01-10 02:44:02 UTC) #3

*** Submitted as https://code.google.com/p/re2/source/detail?r=d4b3de58cdae ***

re2: add dot_nl to the RE2::Options class

This allows clients to set the “s” flag by default for a given
regular expression without the need to mess with the pattern by
prefixing it with “(?s)”.  This matters if the pattern comes
from the user.

Fixes issue 70.

R=rsc
CC=re2-dev
https://codereview.appspot.com/44070048

Committer: Russ Cox <rsc@swtch.com>

Expand All Messages | Collapse All Messages