code review 44070046: runtime: unblock signals when we try to core dump

runtime: unblock signals when we try to core dump
Fixes issue 6988.

[minux1, 2013-12-19 22:24:59]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[iant, 2013-12-19 22:35:27]

https://codereview.appspot.com/44070046/diff/40001/src/pkg/runtime/os_darwin.c
File src/pkg/runtime/os_darwin.c (right):

https://codereview.appspot.com/44070046/diff/40001/src/pkg/runtime/os_darwin....
src/pkg/runtime/os_darwin.c:525: runtime·memclr((byte *)&zero, sizeof zero);
Use sigset_none.
Here and in the other files too.

[minux1, 2013-12-19 22:39:55]

PTAL.

On 2013/12/19 22:35:27, iant wrote:
>
https://codereview.appspot.com/44070046/diff/40001/src/pkg/runtime/os_darwin....
> src/pkg/runtime/os_darwin.c:525: runtime·memclr((byte *)&zero, sizeof zero);
> Use sigset_none.
> Here and in the other files too.
all fixed.

[iant, 2013-12-19 22:59:03]

LGTM

Thanks.

[minux1, 2013-12-20 01:45:10]

*** Submitted as https://code.google.com/p/go/source/detail?r=1c0b5e9550c0 ***

runtime: unblock signals when we try to core dump
Fixes issue 6988.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/44070046

[mikio, 2013-12-20 01:57:17]

leave to minux

https://codereview.appspot.com/44070046/diff/80001/src/pkg/runtime/os_openbsd.c
File src/pkg/runtime/os_openbsd.c (right):

https://codereview.appspot.com/44070046/diff/80001/src/pkg/runtime/os_openbsd...
src/pkg/runtime/os_openbsd.c:307: runtime·sigprocmask(SIG_SETMASK,
&sigset_none);
ouch

[minux1, 2013-12-20 02:03:06]

On Thu, Dec 19, 2013 at 8:57 PM, <mikioh.mikioh@gmail.com> wrote:

> https://codereview.appspot.com/44070046/diff/80001/src/
> pkg/runtime/os_openbsd.c#newcode307
> src/pkg/runtime/os_openbsd.c:307: runtime·sigprocmask(SIG_SETMASK,
> &sigset_none);
> ouch
>
oops, thank you for pointing it out.

https://codereview.appspot.com/38030045