Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(26)

Issue 44070045: New QA assessment questions.

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by bac
Modified:
6 years, 3 months ago
Reviewers:
rharding, mp+199713
Visibility:
Public.

Description

New QA assessment questions. A migration is necessary to remove the old questions and answers and then to reinstate the new ones. I've separated these two tasks into two different migrations for easier testing. Note the second one is forced to reach into Version and call the newly refactored setup_qa_data because initialize is only called if the database has not previously been versioned. https://code.launchpad.net/~bac/charmworld/bug-1257878/+merge/199713 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -132 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/forms/qa_assessment.py View 1 chunk +16 lines, -14 lines 0 comments Download
M charmworld/migrations/migrate.py View 1 chunk +6 lines, -2 lines 0 comments Download
A charmworld/migrations/versions/022_Remove_all_QA_questions_and_data.py View 1 chunk +17 lines, -0 lines 0 comments Download
A charmworld/migrations/versions/023_insert_new_questions.py View 1 chunk +13 lines, -0 lines 0 comments Download
M charmworld/migrations/versions/tests/test_migrations.py View 2 chunks +69 lines, -0 lines 1 comment Download
M charmworld/qa_questions.py View 2 chunks +161 lines, -104 lines 0 comments Download
M charmworld/static/css/base.css View 1 chunk +13 lines, -0 lines 0 comments Download
M charmworld/templates/form/mapping_item.pt View 1 chunk +1 line, -1 line 1 comment Download
M charmworld/templates/qa_edit.pt View 1 chunk +2 lines, -0 lines 0 comments Download
M charmworld/testing/factory.py View 1 chunk +5 lines, -5 lines 0 comments Download
M charmworld/views/charms.py View 3 chunks +11 lines, -6 lines 0 comments Download
M docs/migrations.rst View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
bac
Please take a look.
6 years, 3 months ago (2013-12-19 20:22:21 UTC) #1
rharding
6 years, 3 months ago (2013-12-20 13:48:55 UTC) #2
Code looks good. QA'ing next.

https://codereview.appspot.com/44070045/diff/1/charmworld/migrations/versions...
File charmworld/migrations/versions/tests/test_migrations.py (right):

https://codereview.appspot.com/44070045/diff/1/charmworld/migrations/versions...
charmworld/migrations/versions/tests/test_migrations.py:148: # Test removal of 
QA questions and data.  The new questions will be
double space

https://codereview.appspot.com/44070045/diff/1/charmworld/templates/form/mapp...
File charmworld/templates/form/mapping_item.pt (right):

https://codereview.appspot.com/44070045/diff/1/charmworld/templates/form/mapp...
charmworld/templates/form/mapping_item.pt:5: title='${field.description}'
any reason to change this one from " to '?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b