Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(226)

Issue 44060044: code review 44060044: io/ioutil: use sync.Pool in Discard (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 9 months ago by bradfitz
Modified:
3 years, 9 months ago
Reviewers:
rsc
CC:
golang-codereviews, rsc
Visibility:
Public.

Description

io/ioutil: use sync.Pool in Discard And merge the blackhole.go file back into ioutil, where it once was. It was only in a separate file because it used to have race-vs-!race versions.

Patch Set 1 #

Patch Set 2 : diff -r f57908289898 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f57908289898 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7b554415f8bd https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -26 lines) Patch
R src/pkg/io/ioutil/blackhole.go View 1 1 chunk +0 lines, -23 lines 0 comments Download
M src/pkg/io/ioutil/ioutil.go View 1 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
3 years, 9 months ago (2013-12-20 09:52:08 UTC) #1
rsc
LGTM
3 years, 9 months ago (2013-12-20 14:06:08 UTC) #2
gobot
Replacing golang-dev with golang-codereviews.
3 years, 9 months ago (2013-12-20 16:26:12 UTC) #3
bradfitz
3 years, 9 months ago (2013-12-20 17:38:37 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=fdfc321546e7 ***

io/ioutil: use sync.Pool in Discard

And merge the blackhole.go file back into ioutil,
where it once was. It was only in a separate file
because it used to have race-vs-!race versions.

R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/44060044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted