Issue 44060044: code review 44060044: io/ioutil: use sync.Pool in Discard

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 44060044: code review 44060044: io/ioutil: use sync.Pool in Discard (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 10 months ago by bradfitz

Modified:
10 years, 10 months ago

Reviewers:
rsc

CC:
golang-codereviews, rsc

Visibility:
Public.

Description

io/ioutil: use sync.Pool in Discard And merge the blackhole.go file back into ioutil, where it once was. It was only in a separate file because it used to have race-vs-!race versions.

Patch Set 1 #

Patch Set 2 : diff -r f57908289898 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r f57908289898 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 7b554415f8bd https://go.googlecode.com/hg/ #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -26 lines)			Patch
	R	src/pkg/io/ioutil/blackhole.go	View	1	1 chunk	+0 lines, -23 lines	0 comments	Download
	M	src/pkg/io/ioutil/ioutil.go	View	1	2 chunks	+11 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 10 months ago (2013-12-20 09:52:08 UTC) #1

bradfitz

10 years, 10 months ago (2013-12-20 17:38:37 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=fdfc321546e7 ***

io/ioutil: use sync.Pool in Discard

And merge the blackhole.go file back into ioutil,
where it once was. It was only in a separate file
because it used to have race-vs-!race versions.

R=golang-codereviews, rsc
CC=golang-codereviews
https://codereview.appspot.com/44060044

Expand All Messages | Collapse All Messages