Issue 43960045: code review 43960045: text/template: don't panic when using AddParseTree with...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43960045: code review 43960045: text/template: don't panic when using AddParseTree with... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by josharian

Modified:
11 years, 6 months ago

Reviewers:
r

CC:
golang-codereviews, r

Visibility:
Public.

Description

text/template: don't panic when using AddParseTree with an unparsed template Fixes issue 7032.

Patch Set 2 : diff -r b3caf13d930b https://code.google.com/p/go #

Patch Set 3 : diff -r b3caf13d930b https://code.google.com/p/go #

Total comments: 2

Patch Set 4 : diff -r b3caf13d930b https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
	M	src/pkg/text/template/multi_test.go	View	1 2 3	1 chunk	+12 lines, -0 lines	0 comments	Download
	M	src/pkg/text/template/template.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

josharian

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-12-30 18:24:26 UTC) #1

https://codereview.appspot.com/43960045/diff/40001/src/pkg/text/template/multi_test.go File src/pkg/text/template/multi_test.go (right): https://codereview.appspot.com/43960045/diff/40001/src/pkg/text/template/multi_test.go#newcode262 src/pkg/text/template/multi_test.go:262: // https://code.google.com/p/go/issues/detail?id=7032 // Issue 7032 is sufficient.

11 years, 6 months ago (2013-12-31 00:33:09 UTC) #2

josharian

11 years, 6 months ago (2013-12-31 00:42:52 UTC) #3

11 years, 6 months ago (2013-12-31 01:17:30 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=959a83dadbb9 ***

text/template: don't panic when using AddParseTree with an unparsed template

Fixes issue 7032.

R=golang-codereviews, r
CC=golang-codereviews
https://codereview.appspot.com/43960045

Committer: Rob Pike <r@golang.org>

Expand All Messages | Collapse All Messages