Issue 4383043: Use java.lang.Object instead of Object to allow "Object" to be used as message name.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4383043: Use java.lang.Object instead of Object to allow "Object" to be used as message name.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by Jisi Liu

Modified:
13 years ago

Reviewers:
jasonh, kenton

CC:
kenton+urgent_google.com

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Update java_message.cc and add Object test_bad_identifiers.proto #

Created: 13 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
M	java/src/test/java/com/google/protobuf/test_bad_identifiers.proto	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/google/protobuf/compiler/java/java_message.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/google/protobuf/compiler/java/java_string_field.cc	View		3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

kenton

Agreed with Jason -- test_bad_identifiers.proto in the Java tree should be updated. On Thu, Apr ...

13 years ago (2011-04-07 17:29:01 UTC) #3

Jisi Liu

Done. Sorry I was looking at net/proto2/compiler/java (didn't search the java tree..). It turns out ...

13 years ago (2011-04-08 03:30:06 UTC) #4

kenton

13 years ago (2011-04-08 03:33:04 UTC) #5

LGTM

On Thu, Apr 7, 2011 at 8:30 PM, <liujisi@google.com> wrote:

> Done. Sorry I was looking at net/proto2/compiler/java (didn't search the
> java tree..). It turns out we also need to fix 2 usages in
> java_message.cc to pass the test.
>
>
> On 2011/04/07 17:29:01, kenton wrote:
>
>> Agreed with Jason -- test_bad_identifiers.proto in the Java tree
>>
> should be
>
>> updated.
>>
>
>  On Thu, Apr 7, 2011 at 9:19 AM, <mailto:jasonh@google.com> wrote:
>>
>
>  > code looks fine, can you add a test?
>> >
>> >
>> > http://codereview.appspot.com/4383043/
>> >
>>
>
>
>
> http://codereview.appspot.com/4383043/
>

Expand All Messages | Collapse All Messages