Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(120)

Issue 43780043: code review 43780043: log: fix example (fix build) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by adg
Modified:
11 years, 7 months ago
Reviewers:
bradfitz
CC:
golang-dev
Visibility:
Public.

Description

log: fix example (fix build)

Patch Set 1 #

Patch Set 2 : diff -r 0bce4d8154d3 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/pkg/log/example_test.go View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
adg
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go
11 years, 7 months ago (2013-12-18 06:24:58 UTC) #1
adg
*** Submitted as https://code.google.com/p/go/source/detail?r=12a40bc39413 *** log: fix example (fix build) R=golang-dev CC=golang-dev https://codereview.appspot.com/43780043
11 years, 7 months ago (2013-12-18 06:25:51 UTC) #2
bradfitz
11 years, 7 months ago (2013-12-18 06:26:12 UTC) #3
LGTM

There was another CL for this too.



On Tue, Dec 17, 2013 at 10:24 PM, <adg@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> log: fix example (fix build)
>
> Please review this at https://codereview.appspot.com/43780043/
>
> Affected files (+1, -1 lines):
>   M src/pkg/log/example_test.go
>
>
> Index: src/pkg/log/example_test.go
> ===================================================================
> --- a/src/pkg/log/example_test.go
> +++ b/src/pkg/log/example_test.go
> @@ -17,5 +17,5 @@
>
>         fmt.Print(&buf)
>         // Output:
> -       // logger: example_test.go:15: Hello, log file!
> +       // logger: example_test.go:16: Hello, log file!
>  }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b