Issue 43730043: code review 43730043: runtime: skip broken TestRuntimeGogoBytes on windows

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43730043: code review 43730043: runtime: skip broken TestRuntimeGogoBytes on windows (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by brainman

Modified:
11 years, 7 months ago

Reviewers:
bradfitz

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

runtime: skip broken TestRuntimeGogoBytes on windows

Patch Set 1 #

Patch Set 2 : diff -r a0c8cab3e171 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r a0c8cab3e171 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 4bdb5c0bd2be https://go.googlecode.com/hg/ #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	src/pkg/runtime/runtime_test.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 7 months ago (2013-12-18 03:11:16 UTC) #1

brainman

This CL together with CL 43150043 should get our windows builders running again. Alex

11 years, 7 months ago (2013-12-18 03:12:00 UTC) #2

bradfitz

LGTM On Tue, Dec 17, 2013 at 7:12 PM, <alex.brainman@gmail.com> wrote: > This CL together ...

11 years, 7 months ago (2013-12-18 03:15:02 UTC) #3

brainman

11 years, 7 months ago (2013-12-18 03:17:53 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=091d88caa24f ***

runtime: skip broken TestRuntimeGogoBytes on windows

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/43730043

Expand All Messages | Collapse All Messages