Issue 43710043: code review 43710043: liblink: don't search for an import file with an absolu...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 43710043: code review 43710043: liblink: don't search for an import file with an absolu... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by iant

Modified:
11 years, 7 months ago

Reviewers:
rsc

CC:
rsc, golang-dev

Visibility:
Public.

Description

liblink: don't search for an import file with an absolute path This restores the old behaviour, and makes it possible to continue to use 6g and 6l directly, rather than the go tool, with dot imports.

Patch Set 1 #

Patch Set 2 : diff -r 036ad527e08a https://code.google.com/p/go #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	src/liblink/ld.c	View		1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 7 months ago (2013-12-18 01:18:10 UTC) #1

iant

11 years, 7 months ago (2013-12-18 18:33:49 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=2e4a727b0703 ***

liblink: don't search for an import file with an absolute path

This restores the old behaviour, and makes it possible to
continue to use 6g and 6l directly, rather than the go tool,
with dot imports.

R=rsc
CC=golang-dev
https://codereview.appspot.com/43710043

Expand All Messages | Collapse All Messages