Issue 4357047: Lepsia chybova hlaska pri nacitavani dat z FileStorage

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4357047: Lepsia chybova hlaska pri nacitavani dat z FileStorage (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years ago by anty

Modified:
13 years ago

Reviewers:
ppershing

CC:
fajr-devel+codereview_googlegroups.com

Base URL:
http://fajr.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Lepsia chybova hlaska pri nacitavani dat z FileStorage

Patch Set 1 #

Total comments: 1

Created: 13 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/libfajr/storage/FileStorage.php	View		1 chunk	+4 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

ppershing

13 years ago (2011-04-03 21:13:59 UTC) #2

lgtm

http://codereview.appspot.com/4357047/diff/1/src/libfajr/storage/FileStorage.php
File src/libfajr/storage/FileStorage.php (right):

http://codereview.appspot.com/4357047/diff/1/src/libfajr/storage/FileStorage....
src/libfajr/storage/FileStorage.php:88: $err = error_get_last();
technicky sa moze stat, ze samotny eval vrati false, lebo nejaky expert spravi
"return false;". anyway, to hovorim len tak pre info.

Expand All Messages | Collapse All Messages